UPSTREAM PR #18426: Revert "ggml-cuda: use CMAKE_CUDA_ARCHITECTURES if set when GGML_NATI…#727
Open
UPSTREAM PR #18426: Revert "ggml-cuda: use CMAKE_CUDA_ARCHITECTURES if set when GGML_NATI…#727
Conversation
…VE=ON (#18413)" This reverts commit 4fd59e8.
|
Explore the complete analysis inside the Version Insights I've generated a summary report for your project. Here are the key findings: Performance Summary ReportProject Details:
Version Comparison:
Key FindingsPerformance Impact: ✅ MINIMAL The analysis shows that no modified functions were found with performance changes greater than 2% for both:
SummaryThis pull request (#727) appears to have minimal to no performance impact on the llama.cpp codebase. All modified functions show performance variations within the 2% threshold, which is typically considered within normal variance and not a significant regression or improvement. Recommendation: From a performance perspective, this change appears safe to merge as it does not introduce any notable performance regressions or improvements. |
058a7bf to
c49b379
Compare
534cc78 to
c6d4b6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrored from ggml-org/llama.cpp#18426
…VE=ON (#18413)"
This reverts commit 4fd59e8.
The reason is that fix is only for the Docker builds without GPU and breaks all native builds otherwise. We also cannot allow users to specify
120-realand expect compilation to work at the moment. For Docker builds without GPU the correct way would be to build without GGML_NATIVE