Skip to content

UPSTREAM PR #18426: Revert "ggml-cuda: use CMAKE_CUDA_ARCHITECTURES if set when GGML_NATI…#727

Open
loci-dev wants to merge 1 commit intomainfrom
upstream-PR18426-branch_am17an-cuda-revert-18314
Open

UPSTREAM PR #18426: Revert "ggml-cuda: use CMAKE_CUDA_ARCHITECTURES if set when GGML_NATI…#727
loci-dev wants to merge 1 commit intomainfrom
upstream-PR18426-branch_am17an-cuda-revert-18314

Conversation

@loci-dev
Copy link

Mirrored from ggml-org/llama.cpp#18426

…VE=ON (#18413)"

This reverts commit 4fd59e8.

The reason is that fix is only for the Docker builds without GPU and breaks all native builds otherwise. We also cannot allow users to specify 120-real and expect compilation to work at the moment. For Docker builds without GPU the correct way would be to build without GGML_NATIVE

@loci-review
Copy link

loci-review bot commented Dec 28, 2025

Explore the complete analysis inside the Version Insights

I've generated a summary report for your project. Here are the key findings:

Performance Summary Report

Project Details:

Version Comparison:

  • Base Version: b8001133-46bc-4b58-8e78-3e22fd732519
  • Target Version: 6d193b1f-78b3-41a6-b2e9-b3986ba39cf1

Key Findings

Performance Impact: ✅ MINIMAL

The analysis shows that no modified functions were found with performance changes greater than 2% for both:

  • Response Time - No significant changes detected
  • Throughput Time - No significant changes detected

Summary

This pull request (#727) appears to have minimal to no performance impact on the llama.cpp codebase. All modified functions show performance variations within the 2% threshold, which is typically considered within normal variance and not a significant regression or improvement.

Recommendation: From a performance perspective, this change appears safe to merge as it does not introduce any notable performance regressions or improvements.

@loci-dev loci-dev force-pushed the main branch 27 times, most recently from 058a7bf to c49b379 Compare December 31, 2025 17:08
@loci-dev loci-dev force-pushed the main branch 30 times, most recently from 534cc78 to c6d4b6b Compare January 7, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants