-
Notifications
You must be signed in to change notification settings - Fork 13.9k
Add a couple of file types to the text section #17670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
allozaur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pwilkin looking good in general.
Please run npm run format for linting CI to pass + please update the static build :)
Just when I was getting used to running |
Did you run |
Nope, just npm run build :> |
Busted! 😝 lemme know when you have formatted the code and maybe add a short test video to the PR description? 😊 |
a921e4a to
0484761
Compare
|
@allozaur looks good 😄 |
allozaur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pwilkin just plz do one more rebase and static build and let's merge it
0484761 to
1a414d7
Compare
Fixes #17556
I believe we should at least support the source files in the llama.cpp codebase ;)