Skip to content

Conversation

@pwilkin
Copy link
Collaborator

@pwilkin pwilkin commented Dec 1, 2025

Fixes #17556

I believe we should at least support the source files in the llama.cpp codebase ;)

Copy link
Collaborator

@allozaur allozaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pwilkin looking good in general.

Please run npm run format for linting CI to pass + please update the static build :)

@pwilkin
Copy link
Collaborator Author

pwilkin commented Dec 2, 2025

@pwilkin looking good in general.

Please run npm run format for linting CI to pass + please update the static build :)

Just when I was getting used to running editorconfig-checker on each run, another linter... 😆

@allozaur
Copy link
Collaborator

allozaur commented Dec 2, 2025

Just when I was getting used to running editorconfig-checker on each run, another linter... 😆

Did you run npm run dev locally? It should install git hooks where we have a pre-commit hook checking the linting, types etc.

@pwilkin
Copy link
Collaborator Author

pwilkin commented Dec 2, 2025

Did you run npm run dev locally? It should install git hooks where we have a pre-commit hook checking the linting, types etc.

Nope, just npm run build :>

@allozaur
Copy link
Collaborator

allozaur commented Dec 2, 2025

Did you run npm run dev locally? It should install git hooks where we have a pre-commit hook checking the linting, types etc.

Nope, just npm run build :>

Busted! 😝 lemme know when you have formatted the code and maybe add a short test video to the PR description? 😊

@pwilkin
Copy link
Collaborator Author

pwilkin commented Dec 2, 2025

@allozaur looks good 😄

https://youtu.be/Zy2-AdXqNMU

Copy link
Collaborator

@allozaur allozaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pwilkin just plz do one more rebase and static build and let's merge it

@pwilkin pwilkin merged commit c6d1a00 into ggml-org:master Dec 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misc. bug: Regression on file uploads

2 participants