Misc. bug: Regression on file uploads

[pwilkin]

Name and Version

(pwilkin) pwilkin@SYN-PC-11:/devel/models$ llama-cli --version
load_backend: loaded BLAS backend from /devel/tools/llama.cpp/build/bin/libggml-blas.so
register_backend: registered backend BLAS (1 devices)
register_device: registered device BLAS (OpenBLAS)
ggml_cuda_init: GGML_CUDA_FORCE_MMQ: no
ggml_cuda_init: GGML_CUDA_FORCE_CUBLAS: no
ggml_cuda_init: found 2 CUDA devices:
Device 0: NVIDIA GeForce RTX 5070 Ti, compute capability 12.0, VMM: yes
Device 1: NVIDIA GeForce RTX 5070 Ti, compute capability 12.0, VMM: yes
load_backend: loaded CUDA backend from /devel/tools/llama.cpp/build/bin/libggml-cuda.so
register_backend: registered backend CUDA (2 devices)
register_device: registered device CUDA0 (NVIDIA GeForce RTX 5070 Ti)
register_device: registered device CUDA1 (NVIDIA GeForce RTX 5070 Ti)
ggml_backend_load_best: /devel/tools/llama.cpp/build/bin/libggml-cpu-alderlake.so score: 128
ggml_backend_load_best: /devel/tools/llama.cpp/build/bin/libggml-cpu-icelake.so score: 0
ggml_backend_load_best: /devel/tools/llama.cpp/build/bin/libggml-cpu-haswell.so score: 64
ggml_backend_load_best: /devel/tools/llama.cpp/build/bin/libggml-cpu-skylakex.so score: 0
ggml_backend_load_best: /devel/tools/llama.cpp/build/bin/libggml-cpu-sapphirerapids.so score: 0
ggml_backend_load_best: /devel/tools/llama.cpp/build/bin/libggml-cpu-sandybridge.so score: 21
ggml_backend_load_best: /devel/tools/llama.cpp/build/bin/libggml-cpu-sse42.so score: 5
ggml_backend_load_best: /devel/tools/llama.cpp/build/bin/libggml-cpu-x64.so score: 1
load_backend: loaded CPU backend from /devel/tools/llama.cpp/build/bin/libggml-cpu-alderlake.so
register_backend: registered backend CPU (1 devices)
register_device: registered device CPU (Intel(R) Core(TM) i7-14700KF)
version: 7153 (ea4dc88)
built with cc (Ubuntu 15.2.0-4ubuntu4) 15.2.0 for x86_64-linux-gnu

Operating systems

Linux

Which llama.cpp modules do you know to be affected?

Other (Please specify in the next section)

Command line

Problem description & steps to reproduce

The new file upload file type check is prohibitively restrictive. I cannot upload any source code files because it doesn't recognize them as text (I guess this is the issue with quite a few files types as well). This basically forces one to copy a file to a .txt extension before uploading. The file type detection logic should either be inclusive by default (i.e. exclude certain specific file patterns) or use some sort of content-detection library to determine if file is binary or text.

First Bad Commit

4c91f26

Relevant log output

[allozaur]

Hey @pwilkin, thanks for reporting that! We'll soon release improvements for handling attachments along with refactor changes in #17470, I will make sure to have that issue resolved with it.

[pwilkin]

Nope, not fixed :) I'll push a separate PR.

[allozaur]

Nope, not fixed :) I'll push a separate PR.

Hah, I see now which file types u needed 😄 Thanks for the PR!