[core] Don't skip binding index checks for derived layouts. #8325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
added
type: bug
ErichDonGubler
approved these changes
Oct 10, 2025
Member
ErichDonGubler
left a comment
ErichDonGubler
left a comment
There was a problem hiding this comment.
A CHANGELOG entry might be good for this? I'm not set on that, though.
When deriving a bind group layout for a pipeline, bother to enforce `wgpu_types::Limits::max_bindings_per_bind_group`. Move the check: - from `wgpu_core::device::bgl::EntryMap::from_entries`, which is only used for explicit bind group creation - into `wgpu_core::device::Device::create_bind_group_layout`, which is used for all bind group layout creation.
jimblandy
force-pushed
the
check-derived-bind-group-layout-entry-indices
branch
from
c6cda85 to
9eebc20
Compare
sharmajai
pushed a commit
to sharmajai/wgpu
that referenced
this pull request
Oct 12, 2025
) When deriving a bind group layout for a pipeline, bother to enforce `wgpu_types::Limits::max_bindings_per_bind_group`. Move the check: - from `wgpu_core::device::bgl::EntryMap::from_entries`, which is only used for explicit bind group creation - into `wgpu_core::device::Device::create_bind_group_layout`, which is used for all bind group layout creation.
ErichDonGubler
pushed a commit
that referenced
this pull request
Oct 14, 2025
When deriving a bind group layout for a pipeline, bother to enforce `wgpu_types::Limits::max_bindings_per_bind_group`. Move the check: - from `wgpu_core::device::bgl::EntryMap::from_entries`, which is only used for explicit bind group creation - into `wgpu_core::device::Device::create_bind_group_layout`, which is used for all bind group layout creation.
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Oct 14, 2025
…755052b24c1a78c r=#webgpu-reviewers! Re-vendor backports of [wgpu#8316](gfx-rs/wgpu#8316) and [wgpu#8325](gfx-rs/wgpu#8325) to implement uplifts for bug 1988488 and bug 1986431, respectively, to stable. Differential Revision: https://phabricator.services.mozilla.com/D268620
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Oct 15, 2025
…755052b24c1a78c r=#webgpu-reviewers! Re-vendor backports of [wgpu#8316](gfx-rs/wgpu#8316) and [wgpu#8325](gfx-rs/wgpu#8325) to implement uplifts for bug 1988488 and bug 1986431, respectively, to stable. Differential Revision: https://phabricator.services.mozilla.com/D268620
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/wgpu
that referenced
this pull request
Oct 21, 2025
) When deriving a bind group layout for a pipeline, bother to enforce `wgpu_types::Limits::max_bindings_per_bind_group`. Move the check: - from `wgpu_core::device::bgl::EntryMap::from_entries`, which is only used for explicit bind group creation - into `wgpu_core::device::Device::create_bind_group_layout`, which is used for all bind group layout creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deriving a bind group layout for a pipeline, bother to enforce
wgpu_types::Limits::max_bindings_per_bind_group. Move the check:from
wgpu_core::device::bgl::EntryMap::from_entries, which is only used for explicit bind group creationinto
wgpu_core::device::Device::create_bind_group_layout, which is used for all bind group layout creation.