Reject fragment shader output locations >= max_color_attachments limit
#8316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Current CI failures are unrelated, and are resolved with #8317. |
ErichDonGubler
changed the title
locations > max_color_attachmentslocations > max_color_attachments
ErichDonGubler
added
area: api
ErichDonGubler
changed the title
locations > max_color_attachmentslocations > max_color_attachments
ErichDonGubler
changed the title
locations > max_color_attachmentslocations > max_color_attachments limit
ErichDonGubler
force-pushed
the
erichdongubler-push-boinging-erudite-lemon
branch
from
a8a62f6 to
5f9d9bc
Compare
andyleiserson
approved these changes
Oct 8, 2025
Contributor
andyleiserson
left a comment
andyleiserson
left a comment
There was a problem hiding this comment.
We might also want to impose some limits in naga in cases where large values will result in allocating big arrays for the module or interface info.
ErichDonGubler
changed the title
locations > max_color_attachments limitlocations >= max_color_attachments limit
Member
Author
|
Rebasing with autosquash applied. Also editing the commit message and PR with |
…t `@builtin(position)` warning
ErichDonGubler
force-pushed
the
erichdongubler-push-boinging-erudite-lemon
branch
from
092d0b3 to
d2e2f39
Compare
ErichDonGubler
force-pushed
the
erichdongubler-push-boinging-erudite-lemon
branch
from
d2e2f39 to
48757bb
Compare
ErichDonGubler
force-pushed
the
erichdongubler-push-boinging-erudite-lemon
branch
from
48757bb to
7c27d48
Compare
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Oct 14, 2025
…755052b24c1a78c r=#webgpu-reviewers! Re-vendor backports of [wgpu#8316](gfx-rs/wgpu#8316) and [wgpu#8325](gfx-rs/wgpu#8325) to implement uplifts for bug 1988488 and bug 1986431, respectively, to stable. Differential Revision: https://phabricator.services.mozilla.com/D268620
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Oct 15, 2025
…755052b24c1a78c r=#webgpu-reviewers! Re-vendor backports of [wgpu#8316](gfx-rs/wgpu#8316) and [wgpu#8325](gfx-rs/wgpu#8325) to implement uplifts for bug 1988488 and bug 1986431, respectively, to stable. Differential Revision: https://phabricator.services.mozilla.com/D268620
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a spec. bug (see gpuweb/gpuweb#5341)! 😀 The WebGPU spec. didn't demand that we ensure that this was so, but it was intended to.
rebaseplz
Testing
A test has been added, named
reject_fragment_shader_output_over_max_color_attachments.Checklist
CHANGELOG.mdentry.