Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor texture format to scalar conversion #6451

Merged
merged 5 commits into from
Oct 23, 2024

Conversation

atlv24
Copy link
Contributor

@atlv24 atlv24 commented Oct 23, 2024

Connections
commit pulled from #5537

Description
storage width of 4 bytes is hardcoded which makes adding 64bit texture formats annoying

Testing
existing tests pass

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@atlv24 atlv24 requested a review from a team as a code owner October 23, 2024 16:25
Copy link
Member

@ErichDonGubler ErichDonGubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While breaking, I think the migration is easy enough that this isn't controversial.

@ErichDonGubler ErichDonGubler enabled auto-merge (squash) October 23, 2024 20:00
@ErichDonGubler ErichDonGubler merged commit 64a61ee into gfx-rs:trunk Oct 23, 2024
27 checks passed
@ErichDonGubler ErichDonGubler mentioned this pull request Oct 23, 2024
7 tasks
@ErichDonGubler ErichDonGubler self-assigned this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants