64 bit image atomics #5537
Open
64 bit image atomics #5537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
atlv24
commented
Aug 16, 2024
atlv24
commented
Aug 16, 2024
atlv24
commented
Sep 26, 2024
atlv24
commented
Sep 27, 2024
atlv24
commented
Sep 27, 2024
atlv24
commented
Sep 27, 2024
atlv24
commented
Sep 27, 2024
atlv24
commented
Sep 30, 2024
atlv24
commented
Sep 30, 2024
atlv24
commented
Sep 30, 2024
JMS55
reviewed
Oct 1, 2024
…r support detection for metal, directx, and vulkan
jimblandy
requested changes
Oct 2, 2024
|
@atlv24 Earlier today you asked me for a suggestion about the texture usages, and a review of the tests. I've posted those now. Is there anything else you need before breaking this up into independent commits for review? |
|
@jimblandy I've broken it into independent commits already, thanks for the feedback. I've implemented the texture usage stuff, now im working on the tests. :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Part of an incoming series of PRs needed by #5123
Others in this series: #5155 #5154 #5383
Addresses #4424
Depends on #5383
Ultimately for bevy meshlets pipeline bevyengine/bevy#10164
Description
Adds 64 bit image atomics to Vulkan, DirectX, and Metal backends. Emulates using RG32Uint on platforms where R64Uint is not available (directX, metal).
Testing
naga tests and runtime tests are included
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.