Remove workspace inheritance #3295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3295 +/- ##
==========================================
- Coverage 65.63% 65.62% -0.02%
==========================================
Files 82 82
Lines 39479 39490 +11
==========================================
+ Hits 25914 25917 +3
- Misses 13565 13573 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
We're considering this because of rust-lang/cargo#11192. Using workspace inheritance is great, and wgpu should do it - but it makes vendoring impossible. |
jimblandy
force-pushed
the
remove-workspace-inheritance
branch
from
79a2808
to
5d3af89
Compare
|
I'll take care of re-introducing the inheritance as soon as it's workable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reluctantly reverts #3107. Using workspace inheritance is great, and wgpu should do it - but it makes vendoring impossible because of rust-lang/cargo#11192. Until that's fixed, wgpu will have to hold off on using workspace inheritance.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Description
Describe what problem this is solving, and how it's solved.
Testing
Explain how this change is tested.