-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove workspace inheritance #3295
Remove workspace inheritance #3295
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3295 +/- ##
==========================================
- Coverage 65.63% 65.62% -0.02%
==========================================
Files 82 82
Lines 39479 39490 +11
==========================================
+ Hits 25914 25917 +3
- Misses 13565 13573 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
We're considering this because of rust-lang/cargo#11192. Using workspace inheritance is great, and wgpu should do it - but it makes vendoring impossible. |
79a2808
to
5d3af89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cry
I'll take care of re-introducing the inheritance as soon as it's workable. |
This reluctantly reverts #3107. Using workspace inheritance is great, and wgpu should do it - but it makes vendoring impossible because of rust-lang/cargo#11192. Until that's fixed, wgpu will have to hold off on using workspace inheritance.
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Description
Describe what problem this is solving, and how it's solved.
Testing
Explain how this change is tested.