Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce workspace inheritance #3407

Open
jimblandy opened this issue Jan 19, 2023 · 6 comments
Open

Reintroduce workspace inheritance #3407

jimblandy opened this issue Jan 19, 2023 · 6 comments
Labels
area: infrastructure Testing, building, coordinating issues external: upstream Issues happening in lower level APIs or platforms

Comments

@jimblandy
Copy link
Member

In #3295, we had to remove the use of workspace inheritance from wgpu, because of rust-lang/cargo#11192. It seems like rust-lang/cargo#11414 has fixed the problem, so we should try re-introducing inheritance and see how that goes.

@jimblandy jimblandy added external: upstream Issues happening in lower level APIs or platforms area: infrastructure Testing, building, coordinating issues labels Jan 19, 2023
@jimblandy
Copy link
Member Author

Mozilla is tracking this in Bugzilla 1804530.

@teoxoy
Copy link
Member

teoxoy commented Jan 31, 2023

The version of cargo with the fix will be part of rust 1.68, scheduled for 9th March. We also need to wait for mozilla-central to upgrade.

@jimblandy
Copy link
Member Author

Confirmed that Cargo 1.68 does indeed fix this.

At the moment, Firefox 115's MSRV is Cargo 1.66, so we still need to wait a little longer.

@cwfitzgerald
Copy link
Member

@jimblandy could you link again where we can tell ff's msrv? Would like to add it to our own documentation.

@jimblandy
Copy link
Member Author

@jimblandy
Copy link
Member Author

It seems like the MSRV in Firefox is now 1.70, so maybe we can fix this:
https://searchfox.org/mozilla-central/source/python/mozboot/mozboot/util.py#14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: infrastructure Testing, building, coordinating issues external: upstream Issues happening in lower level APIs or platforms
Projects
None yet
Development

No branches or pull requests

3 participants