-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ray Query support #2256
Ray Query support #2256
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #2256 +/- ##
==========================================
+ Coverage 81.96% 82.18% +0.22%
==========================================
Files 80 82 +2
Lines 43312 44261 +949
==========================================
+ Hits 35502 36378 +876
- Misses 7810 7883 +73
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is interesting. I don't fully understand the ray tracing API, but I've tried to follow what's going on as best I could. Just a few points to address.
@kvark By the way, I went ahead and pushed a commit that expands on the documentation, so be sure to pull before working on the branch. If the docs aren't accurate, feel free to just take the commit out. |
…f an AST constructor
@jimblandy thanks for the review! Everything should be addressed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Give my RayDesc
fix a look, and then feel free to merge if it seems okay.
Much nicer than my version, thank you! |
Path support:
Note: PR also adds basic infra for specially generated types in IR, which may be handy for #1161