Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change frexp and modf to work with structures #1161

Closed
kvark opened this issue Aug 3, 2021 · 4 comments · Fixed by #2454
Closed

Change frexp and modf to work with structures #1161

kvark opened this issue Aug 3, 2021 · 4 comments · Fixed by #2454
Labels
area: middle Intermediate representation help wanted Extra attention is needed kind: feature New feature or request
Milestone
WGSL Specificatio...

Comments

@kvark
Copy link
Member

kvark commented Aug 3, 2021

See gpuweb/gpuweb#1973
I think this change needs to be done at IR level.
@kvark kvark added kind: feature New feature or request help wanted Extra attention is needed area: middle Intermediate representation labels Aug 3, 2021
@kvark kvark added this to the WebGPU MVP milestone Aug 3, 2021
@kvark
Copy link
Member Author

kvark commented Sep 27, 2021

Similar work needs to be done for atomic compare+exchange - gpuweb/gpuweb#2113
I think all of this should wait for #1419 first.

@kvark kvark modified the milestones: WebGPU MVP, Version 0.7 Sep 27, 2021
@kvark
Copy link
Member Author

kvark commented Sep 30, 2021

This isn't urgent for the release.

@kvark kvark mentioned this issue Sep 30, 2021
Closed
5 tasks
@kvark kvark removed this from the Version 0.7 milestone Oct 7, 2021
@kvark kvark mentioned this issue Feb 28, 2022
Closed
@teoxoy teoxoy added this to the WGSL Specification V1 milestone Apr 30, 2022
@kvark kvark mentioned this issue Feb 17, 2023
Merged
5 tasks
@cwfitzgerald
Copy link
Member

Currently bumping up against this when targeting WebGPU, as wgpu's water example uses modf.

@kvark
Copy link
Member Author

kvark commented Apr 19, 2023

This should be simpler now that #2256 is in, which contains infra to create IR structure types.

This was referenced Aug 22, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: middle Intermediate representation help wanted Extra attention is needed kind: feature New feature or request
Projects
None yet
Milestone
WGSL Specification V1
3 participants
@kvark @cwfitzgerald @teoxoy