Upgrade to raw-window-handle v0.3#3050
Conversation
We can't merge until it's resolved. Could |
|
rust-windowing/winit#1187 Not much point in winit continuing to support the old trait imo. |
Sorry, I should have made that clearer. I don't intend for this to be merged until the next |
|
|
|
Just added a commit to upgrade |
antonok-edm
force-pushed
the
raw-window-handle-0.3
branch
from
15b4ef8 to
c98897f
Compare
|
How broken line is even affected by this change? |
|
Seems to be the fix according to this |
|
Apologies for the breakage! Unfortunately it's pointing out places that will invoke undefined behavior in future versions of rust. If any help is needed, I can send a PR later today. |
antonok-edm
force-pushed
the
raw-window-handle-0.3
branch
from
d533571 to
24d52ef
Compare
|
Looks like |
|
Would you mind squashing the commits together? |
support raw XCB handles bump winit to 0.20.0-alpha4 fix objc macro return type inference failure
antonok-edm
force-pushed
the
raw-window-handle-0.3
branch
from
24d52ef to
e7b421f
Compare
|
@kvark done |
|
Thank you! |
3050: Upgrade to raw-window-handle v0.3 r=kvark a=antonok-edm Reopening #3037 against `master`, for merge whenever ready. Note that compiling examples currently doesn't work because `winit` still imports the old version of `raw-window-handle`; the two versions of the traits are incompatible. PR checklist: - [x] `make` succeeds (on *nix) - [x] `make reftests` succeeds - [x] tested examples with the following backends: `vulkan` - [x] `rustfmt` run on changed code Co-authored-by: Anton Lazarev <antonok35@gmail.com>
Build succeeded |
5 participants
Reopening #3037 against
master, for merge whenever ready.Note that compiling examples currently doesn't work because
winitstill imports the old version ofraw-window-handle; the two versions of the traits are incompatible.PR checklist:
makesucceeds (on *nix)make reftestssucceedsvulkanrustfmtrun on changed code