[mtl] new autorelease #2267
Merged
[mtl] new autorelease #2267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grovesNL
approved these changes
Jul 24, 2018
| @@ -721,7 +722,6 @@ impl Journal { | |||
| } | |||
|
|
|||
| fn record(&self, command_buf: &metal::CommandBufferRef) { | |||
| let _ap = AutoreleasePool::new(); // for encoder creation | |||
There was a problem hiding this comment.
This removal seems ok but maybe we should indicate that this is handled by https://github.com/gfx-rs/gfx/pull/2267/files#diff-abc29e1de3205709a964ff5e3b0e6333R1494 instead
There was a problem hiding this comment.
I don't know the best way for us to enforce the autorelease pools, tbh. Just trying to put comments doesn't protect us against a breakage during refactor, or from using a method accidentally that requires a pool but we don't have one...
|
Let's keep thinking on how to enforce this nicer... |
bors bot
added a commit
that referenced
this pull request
Jul 24, 2018
2267: [mtl] new autorelease r=grovesNL a=kvark Fixes the time wasted on setting up temporary autorelease pools, mostly. Although the resulting FPS doesn't appear to be affected. At least we no longer depend on core-foundation :) cc @jrmuizel (and thanks!) for the way it looks now PR checklist: - [ ] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [x] tested examples with the following backends: metal - [ ] `rustfmt` run on changed code Co-authored-by: Dzmitry Malyshau <[email protected]>
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the time wasted on setting up temporary autorelease pools, mostly. Although the resulting FPS doesn't appear to be affected. At least we no longer depend on core-foundation :)
cc @jrmuizel (and thanks!) for the way it looks now
PR checklist:
makesucceeds (on *nix)make reftestssucceedsrustfmtrun on changed code