[mtl] minimize creation of render passes #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
grovesNL
approved these changes
Jun 25, 2018
| @@ -774,7 +774,11 @@ impl CommandSink { | |||
| CommandSink::Deferred { ref mut passes, ref mut is_encoding } => { | |||
| *is_encoding = keep_open; | |||
| passes.push(soft::Pass::Render { | |||
| desc: descriptor.to_owned(), | |||
| //Note: the original descriptor belongs to the framebuffer, | |||
| // and will me mutated afterwards. | |||
| //Note: the original descriptor belongs to the framebuffer, | ||
| // and will me mutated afterwards. | ||
| desc: unsafe { | ||
| msg_send![descriptor, copy] |
There was a problem hiding this comment.
Could we somehow specify whether the copy is actually needed to avoid this when it hasn't changed?
|
The copy is needed there anyway in most cases: for copies and blits we know the descriptor is different, otherwise we wouldn't have multiple passes. For real render passes the framebuffer still needs to own one to mutate later, so retaining a strong reference here is not an option.
… On Jun 24, 2018, at 23:12, Josh Groves ***@***.***> wrote:
@grovesNL approved this pull request.
Looks good to me 👍 it would be good to try with the CTS too
In src/backend/metal/src/command.rs:
> @@ -774,7 +774,11 @@ impl CommandSink {
CommandSink::Deferred { ref mut passes, ref mut is_encoding } => {
*is_encoding = keep_open;
passes.push(soft::Pass::Render {
- desc: descriptor.to_owned(),
+ //Note: the original descriptor belongs to the framebuffer,
+ // and will me mutated afterwards.
nit: me -> be
In src/backend/metal/src/command.rs:
> @@ -774,7 +774,11 @@ impl CommandSink {
CommandSink::Deferred { ref mut passes, ref mut is_encoding } => {
*is_encoding = keep_open;
passes.push(soft::Pass::Render {
- desc: descriptor.to_owned(),
+ //Note: the original descriptor belongs to the framebuffer,
+ // and will me mutated afterwards.
+ desc: unsafe {
+ msg_send![descriptor, copy]
Could we somehow specify whether the copy is actually needed to avoid this when it hasn't changed?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
bors r=grovesNL |
bors bot
added a commit
that referenced
this pull request
Jun 25, 2018
2178: [mtl] minimize creation of render passes r=grovesNL a=kvark PR checklist: - [x] `make` succeeds (on *nix) - [x] `make reftests` succeeds - [ ] tested examples with the following backends: The logic is changed in the following way: - a framebuffer still keeps a hold of a render pass descriptor, but now behind a mutex - starting a render pass mutates that locked descriptor in place - if a command buffer is deferred, only then we copy the whole descriptor out - careful treatment of image blits/clears is done to re-use the RP descriptor more often Note: doesn't seem to affect Dota framerate considerably Co-authored-by: Dzmitry Malyshau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist:
makesucceeds (on *nix)make reftestssucceedsThe logic is changed in the following way:
Note: doesn't seem to affect Dota framerate considerably