Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pipeline definition macro #1075

Merged
merged 1 commit into from
Nov 1, 2016
Merged

Fix pipeline definition macro #1075

merged 1 commit into from
Nov 1, 2016

Conversation

msiglreith
Copy link
Contributor

@msiglreith msiglreith commented Nov 1, 2016

use $crate; is not allowed due to recent restrictions and use super::*; won't import the gfx crate. (allowed in future but feature gated rust-lang/rfcs#1560)

Closes #1070

@kvark
Copy link
Member

kvark commented Nov 1, 2016

Thanks!
@homu r+

@homu
Copy link
Contributor

homu commented Nov 1, 2016

📌 Commit 8c70b3c has been approved by kvark

@homu homu merged commit 8c70b3c into gfx-rs:master Nov 1, 2016
homu added a commit that referenced this pull request Nov 1, 2016
Fix pipeline definition macro

`use $crate;` is not allowed due to recent restrictions and `use super::*;` won't import the gfx crate. (allowed in future but feature gated rust-lang/rfcs#1560)

Closes #1070
@homu
Copy link
Contributor

homu commented Nov 1, 2016

⚡ Test exempted - status

@mitchmindtree
Copy link
Contributor

I'm not sure that this PR results in the same behaviour?

My understanding is that the new use super::gfx; line assumes that either extern crate gfx; or pub use gfx; exists in the super module, while the original use $crate; does not. This PR would break any downstream crates that don't happen to invoke gfx_pipeline! in the same module that they import the gfx crate, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants