-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for go 1.17 and darwin-arm64 (Apple Silicon) #911
Conversation
nklmilojevic
commented
Jul 26, 2021
•
edited
Loading
edited
- Changes from go 1.13/1.15 to go 1.16
- Adds matrix build and binaries for arm64 (Apple Silicon specifically)
Any maintainers around? cc @ajvb |
I would really appreciate ARM binaries too. Please keep this project up-to-date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this!
@autrilla @ajvb Hello guys, having arm64 build is something we desperately need. Thank you, |
Only offering a stop gap; I've temporarily worked around the "lack" of $ GO111MODULE=on
$ GO15VENDOREXPERIMENT=1
$ ${GOROOT}/bin/go install go.mozilla.org/sops/v3/cmd/sops@v${TARGET_SOPS_VERSION}
$ ${GOPATH}/bin/sops --version NOTE: This project's $ go get -u go.mozilla.org/sops/v3/cmd/sops
$ cd $GOPATH/src/go.mozilla.org/sops/
$ git checkout v${TARGET_SOPS_VERSION}
$ make install |
This would be a very welcome change, since with Apple discontinuing Intel MacBook Pros, it's becoming critical to have built-binaries of sops for arm64 distros. We can build from source, but plenty of toolchains depend on pre-built binaries to load directly |
It would be great to take advantage of this PR, and configure the build and release of ARM64 binary for Linux as well. |
pick changes form getsops#911
@nklmilojevic can you rebase this off the latest so it picks up the 1.17 changes that were merged? |
hopefully @rforsythe or @ajvb can approve this and cut a release soon to at least get support for it. There are several golang CVEs that are showing in scans against the binary. Most are false positives but still show in scans for go 1.14,1.15,1.16 |
Thank you very much @nklmilojevic! |