Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Accept linux snapshot #676

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Conversation

loewenheim
Copy link
Contributor

@loewenheim loewenheim commented Feb 14, 2022

#skip-changelog

@loewenheim loewenheim requested a review from a team February 14, 2022 10:29
@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2022

Warnings
⚠️ Snapshot changes likely affect Sentry tests. If the Sentry-Symbolicator Integration Tests in CI are failing for your PR, please check the symbolicator test suite in Sentry and update snapshots as needed.
Instructions for snapshot changes

Sentry runs a symbolicator integration test suite located at tests/symbolicator/. Changes in this PR will likely result in snapshot diffs in Sentry, which will break the master branch and in-progress PRs.

Follow these steps to update snapshots in Sentry:

  1. Check out latest Sentry master and enable the virtualenv.
  2. Enable symbolicator (symbolicator: true) in sentry via ~/.sentry/config.yml.
  3. Make sure your other devservices are running via sentry devservices up --exclude symbolicator. If
    they're already running, stop symbolicator with sentry devservices down symbolicator. You want to use your
    own development symbolicator to update the snapshots.
  4. Run your development symbolicator on port 3021, or whatever port symbolicator is configured to use
    in ~/.sentry/config.yml.
  5. Export SENTRY_SNAPSHOTS_WRITEBACK=1 to automatically update the existing snapshots with your new
    results and run symbolicator tests with pytest (pytest tests/symbolicator).
  6. Review snapshot changes locally, then create a PR to Sentry.
  7. Merge the Symbolicator PR, then merge the Sentry PR.

Generated by 🚫 dangerJS against 7da4be3

@loewenheim loewenheim merged commit ccc056f into release/rust-minidump Feb 14, 2022
@loewenheim loewenheim deleted the test/snapshot branch February 14, 2022 11:32
loewenheim added a commit that referenced this pull request Sep 14, 2022
This includes the following fixes:

- Correctly resolve the `DW_AT_producer` attribute of DWARF files ([#676](getsentry/symbolic#676))
- Improve _sigtramp workaround and explanation ([#662](getsentry/symbolic#662))
- Slightly lower demangling recursion limit ([#655](getsentry/symbolic#655))
loewenheim added a commit that referenced this pull request Sep 14, 2022
This includes the following fixes:

- Correctly resolve the `DW_AT_producer` attribute of DWARF files ([#676](getsentry/symbolic#676))
- Improve _sigtramp workaround and explanation ([#662](getsentry/symbolic#662))
- Slightly lower demangling recursion limit ([#655](getsentry/symbolic#655))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants