Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(symbolication): Introduce ProcError struct #655

Merged
merged 1 commit into from
Feb 8, 2022
Merged

ref(symbolication): Introduce ProcError struct #655

merged 1 commit into from
Feb 8, 2022

Conversation

loewenheim
Copy link
Contributor

@loewenheim loewenheim commented Feb 4, 2022 •
edited
Loading

This is another piece of #645.

#skip-changelog

@loewenheim loewenheim requested a review from a team February 4, 2022 12:38
@codecov-commenter
Copy link

Codecov Report

Merging #655 (d3b7ad1) into master (41ace77) will decrease coverage by 0.14%.
The diff coverage is 5.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #655      +/-   ##
==========================================
- Coverage   73.64%   73.50%   -0.15%     
==========================================
  Files          47       47              
  Lines       10532    10548      +16     
==========================================
- Hits         7756     7753       -3     
- Misses       2776     2795      +19
Impacted Files Coverage Δ
crates/symbolicator/src/services/symbolication.rs 77.78% <5.88%> (-0.76%) ⬇️
crates/symbolicator/src/services/symcaches.rs 93.98% <0.00%> (-0.38%) ⬇️
crates/symbolicator/src/services/cacher.rs 83.60% <0.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41ace77...d3b7ad1. Read the comment docs.

@loewenheim loewenheim merged commit e0bf268 into master Feb 8, 2022
@loewenheim loewenheim deleted the ref/proc-error branch February 8, 2022 11:48
loewenheim added a commit that referenced this pull request Sep 14, 2022
@loewenheim
deps: symbolic 9.1.1 -> 9.1.2
4172309 
This includes the following fixes:

- Correctly resolve the `DW_AT_producer` attribute of DWARF files ([#676](getsentry/symbolic#676))
- Improve _sigtramp workaround and explanation ([#662](getsentry/symbolic#662))
- Slightly lower demangling recursion limit ([#655](getsentry/symbolic#655))
loewenheim added a commit that referenced this pull request Sep 14, 2022
@loewenheim
deps: symbolic 9.1.1 -> 9.1.2 (#876)
3d52f9b 
This includes the following fixes:

- Correctly resolve the `DW_AT_producer` attribute of DWARF files ([#676](getsentry/symbolic#676))
- Improve _sigtramp workaround and explanation ([#662](getsentry/symbolic#662))
- Slightly lower demangling recursion limit ([#655](getsentry/symbolic#655))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flub flub flub approved these changes

@Swatinem Swatinem Swatinem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@loewenheim @codecov-commenter @flub @Swatinem