Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mep): add commit log config to generic metrics storages #2931

Merged
merged 2 commits into from
Jul 13, 2022

Conversation

onewland
Copy link
Contributor

@onewland onewland commented Jul 12, 2022

Created topics in #2928, now let's use 'em

@onewland onewland requested a review from a team as a code owner July 12, 2022 20:05
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2022

Codecov Report

Merging #2931 (4b8bd49) into master (03d8b70) will decrease coverage by 0.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2931      +/-   ##
==========================================
- Coverage   92.92%   92.56%   -0.36%     
==========================================
  Files         635      635              
  Lines       29085    29085              
==========================================
- Hits        27026    26922     -104     
- Misses       2059     2163     +104     
Impacted Files Coverage Δ
snuba/datasets/storages/generic_metrics.py 96.15% <ø> (ø)
...nsactions_onpremise_fix_orderby_and_partitionby.py 32.00% <0.00%> (-52.00%) ⬇️
...ts/0010_groupedmessages_onpremise_compatibility.py 51.11% <0.00%> (-48.89%) ⬇️
tests/migrations/test_runner_individual.py 52.74% <0.00%> (-40.66%) ⬇️
...ns/snuba_migrations/events/0014_backfill_errors.py 92.72% <0.00%> (-3.64%) ⬇️
snuba/migrations/table_engines.py 95.50% <0.00%> (-3.38%) ⬇️
snuba/clusters/cluster.py 95.65% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03d8b70...4b8bd49. Read the comment docs.

@onewland onewland merged commit 69c2362 into master Jul 13, 2022
@onewland onewland deleted the add-commit-logs-to-gen-metrics-storages branch July 13, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants