-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mep): add commit log topics config #2928
feat(mep): add commit log topics config #2928
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2928 +/- ##
==========================================
- Coverage 92.90% 92.85% -0.06%
==========================================
Files 632 635 +3
Lines 29136 29083 -53
==========================================
- Hits 27070 27006 -64
- Misses 2066 2077 +11
Continue to review full report at Codecov.
|
Added the topics to validation in a separate PR so that we can deploy this, then do https://github.com/getsentry/ops/pull/4967, and then finally roll out the rest of this PR. |
@@ -119,6 +119,7 @@ def produce_policy_creator() -> DeadLetterQueuePolicy: | |||
processor=GenericSetsMetricsProcessor(), | |||
default_topic=Topic.GENERIC_METRICS, | |||
dead_letter_queue_policy_creator=produce_policy_creator, | |||
commit_log_topic=Topic.GENERIC_METRICS_SETS_COMMIT_LOG, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to move this line (and the distributions equivalent) into a separate PR. So we create the topics first and have them in topics.py but then start actually producing to them later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing that now, and then I'll merge and then we can do the ops PR
No description provided.