Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mep): add commit log topics config #2928

Merged
merged 3 commits into from
Jul 12, 2022

Conversation

onewland
Copy link
Contributor

No description provided.

@onewland onewland requested a review from a team as a code owner July 11, 2022 17:43
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2022

Codecov Report

Merging #2928 (da3c46b) into master (d6eb346) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2928      +/-   ##
==========================================
- Coverage   92.90%   92.85%   -0.06%     
==========================================
  Files         632      635       +3     
  Lines       29136    29083      -53     
==========================================
- Hits        27070    27006      -64     
- Misses       2066     2077      +11     
Impacted Files Coverage Δ
snuba/settings/validation.py 71.87% <ø> (ø)
snuba/utils/streams/topics.py 100.00% <100.00%> (ø)
snuba/settings/settings_distributed.py 0.00% <0.00%> (-100.00%) ⬇️
snuba/settings/settings_test_distributed.py 0.00% <0.00%> (-100.00%) ⬇️
...ts/0010_groupedmessages_onpremise_compatibility.py 95.55% <0.00%> (-4.45%) ⬇️
snuba/optimize.py 87.50% <0.00%> (-3.75%) ⬇️
snuba/migrations/table_engines.py 95.50% <0.00%> (-3.38%) ⬇️
...nsactions_onpremise_fix_orderby_and_partitionby.py 81.33% <0.00%> (-2.67%) ⬇️
tests/migrations/test_runner_individual.py 91.20% <0.00%> (-2.20%) ⬇️
snuba/clusters/cluster.py 94.92% <0.00%> (-1.45%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6eb346...da3c46b. Read the comment docs.

@onewland
Copy link
Contributor Author

@mwarkentin
Copy link
Member

Added the topics to validation in a separate PR so that we can deploy this, then do https://github.com/getsentry/ops/pull/4967, and then finally roll out the rest of this PR.

#2930

@@ -119,6 +119,7 @@ def produce_policy_creator() -> DeadLetterQueuePolicy:
processor=GenericSetsMetricsProcessor(),
default_topic=Topic.GENERIC_METRICS,
dead_letter_queue_policy_creator=produce_policy_creator,
commit_log_topic=Topic.GENERIC_METRICS_SETS_COMMIT_LOG,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to move this line (and the distributions equivalent) into a separate PR. So we create the topics first and have them in topics.py but then start actually producing to them later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing that now, and then I'll merge and then we can do the ops PR

@onewland onewland changed the title feat(mep): add commit log to generic metrics sets, distributions feat(mep): add commit log topics config Jul 12, 2022
@onewland onewland merged commit 892cf59 into master Jul 12, 2022
@onewland onewland deleted the add-commit-log-to-generic-metrics-sets-distributions branch July 12, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants