Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rate-limit): Don't override SerializableException constructor #2797

Merged
merged 2 commits into from
Jun 8, 2022
Merged

fix(rate-limit): Don't override SerializableException constructor #2797

merged 2 commits into from
Jun 8, 2022

Commits on Jun 8, 2022

  1. fix(rate-limit): Don't override SerializableException constructor 

    Overriding SerializableException constructor is a bad idea since making
the original exception back from a serialized version does not work
correctly. Use extra_data instead.
    @nikhars
    nikhars committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    31a81ba View commit details
    Browse the repository at this point in the history

  2. Add the recording of metrics code back

    @nikhars
    nikhars committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    c24e798 View commit details
    Browse the repository at this point in the history