fix(rate-limit): Don't override SerializableException constructor #2797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overriding SerializableException constructor is a bad idea since making the original exception back from a serialized version does not work correctly. Use extra_data instead.
Codecov Report
@@ Coverage Diff @@
## master #2797 +/- ##
=======================================
Coverage 92.82% 92.82%
=======================================
Files 609 609
Lines 28593 28600 +7
=======================================
+ Hits 26541 26548 +7
Misses 2052 2052
Continue to review full report at Codecov.
|
volokluev
approved these changes
Jun 8, 2022
snuba/state/rate_limit.py
Outdated
Comment on lines
284
to
285
| scope = exc.extra_data.get("scope", "") | ||
| name = exc.extra_data.get("name", "") |
There was a problem hiding this comment.
note: if you wanted to have the exc.scope property you could still do it. That method would just get it from extra_data
| @@ -86,6 +86,14 @@ def _get_registry() -> _ExceptionRegistry: | |||
|
|
|||
|
|
|||
| class SerializableException(Exception): | |||
| """ | |||
There was a problem hiding this comment.
You could enforce this in the __init_subclass__ function if you wanted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overriding SerializableException constructor is a bad idea since making
the original exception back from a serialized version does not work
correctly. Use extra_data instead.