Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat(subscriptions): Adds metrics topics to topics validation" #2313

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Revert "feat(subscriptions): Adds metrics topics to topics validation" #2313

merged 1 commit into from
Dec 20, 2021

Conversation

ahmedetefy
Copy link
Contributor

Reverts #2303

@ahmedetefy ahmedetefy requested a review from a team as a code owner December 20, 2021 15:51
@ahmedetefy ahmedetefy enabled auto-merge (squash) December 20, 2021 15:53
@ahmedetefy ahmedetefy merged commit 63fe3d2 into master Dec 20, 2021
@ahmedetefy ahmedetefy deleted the revert-2303-cra-metrics/validate_metrics_topics branch December 20, 2021 16:05
ahmedetefy added a commit that referenced this pull request Dec 22, 2021
@ahmedetefy
Revert "Revert "feat(subscriptions): Adds metrics topics to topics va…
ec5c538 
…lidation (#2303)" (#2313)"

This reverts commit 63fe3d2.
@ahmedetefy ahmedetefy mentioned this pull request Dec 22, 2021
Merged
ahmedetefy added a commit that referenced this pull request Dec 22, 2021
@ahmedetefy
Revert "Revert "feat(subscriptions): Adds metrics topics to topics va…
c3b5db7 
…lidation (#2303)" (#2313)"

This reverts commit 63fe3d2.
ahmedetefy added a commit that referenced this pull request Dec 22, 2021
@ahmedetefy
Revert "Revert "feat(subscriptions): Adds metrics topics to topics va…
1e1b276 
…lidation (#2303)" (#2313)"

This reverts commit 63fe3d2.
ahmedetefy added a commit that referenced this pull request Dec 23, 2021
@ahmedetefy
Revert "Revert "feat(subscriptions): Adds metrics topics to topics va…
3bd43af 
…lidation (#2303)" (#2313)"

This reverts commit 63fe3d2.
ahmedetefy added a commit that referenced this pull request Jan 11, 2022
@ahmedetefy
feat(subscriptions): Adds metrics topics to topics validation (#2326)
5b7f1ce 
* Revert "Revert "feat(subscriptions): Adds metrics topics to topics validation (#2303)" (#2313)"

This reverts commit 63fe3d2.

* Incorporate review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volokluev volokluev volokluev approved these changes

@lynnagara lynnagara lynnagara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmedetefy @lynnagara @volokluev