Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(subscriptions): Adds metrics topics to topics validation #2303

Merged
merged 2 commits into from
Dec 20, 2021

Conversation

ahmedetefy
Copy link
Contributor

No description provided.

@ahmedetefy ahmedetefy requested a review from a team as a code owner December 17, 2021 11:24
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2021

Codecov Report

Merging #2303 (3d1153f) into master (b99d10e) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2303      +/-   ##
==========================================
- Coverage   92.77%   92.71%   -0.07%     
==========================================
  Files         557      557              
  Lines       25615    25615              
==========================================
- Hits        23765    23748      -17     
- Misses       1850     1867      +17     
Impacted Files Coverage Δ
snuba/settings/validation.py 65.51% <ø> (ø)
snuba/settings/settings_distributed.py 0.00% <0.00%> (-100.00%) ⬇️
snuba/settings/settings_test_distributed.py 0.00% <0.00%> (-100.00%) ⬇️
snuba/optimize.py 83.72% <0.00%> (-6.98%) ⬇️
...ts/0010_groupedmessages_onpremise_compatibility.py 95.55% <0.00%> (-4.45%) ⬇️
...nsactions_onpremise_fix_orderby_and_partitionby.py 81.33% <0.00%> (-2.67%) ⬇️
snuba/migrations/table_engines.py 96.29% <0.00%> (-2.47%) ⬇️
tests/migrations/test_runner_individual.py 98.23% <0.00%> (-1.77%) ⬇️
snuba/clusters/cluster.py 93.16% <0.00%> (-1.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b99d10e...3d1153f. Read the comment docs.

@ahmedetefy ahmedetefy merged commit f49e8fc into master Dec 20, 2021
@ahmedetefy ahmedetefy deleted the cra-metrics/validate_metrics_topics branch December 20, 2021 09:08
ahmedetefy added a commit that referenced this pull request Dec 22, 2021
ahmedetefy added a commit that referenced this pull request Dec 22, 2021
ahmedetefy added a commit that referenced this pull request Dec 22, 2021
ahmedetefy added a commit that referenced this pull request Dec 23, 2021
ahmedetefy added a commit that referenced this pull request Jan 11, 2022
* Revert "Revert "feat(subscriptions): Adds metrics topics to topics validation (#2303)" (#2313)"

This reverts commit 63fe3d2.

* Incorporate review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants