Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(proguard): Remove separate queue #74198

Merged
merged 1 commit into from
Jul 15, 2024
Merged

ref(proguard): Remove separate queue #74198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/sentry/conf/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -866,7 +866,6 @@ def SOCIAL_AUTH_DEFAULT_USERNAME() -> str:
Queue("email.inbound", routing_key="email.inbound"),
Queue("events.preprocess_event", routing_key="events.preprocess_event"),
Queue("events.process_event", routing_key="events.process_event"),
Queue("events.process_event_proguard", routing_key="events.process_event_proguard"),
Queue(
"events.reprocessing.preprocess_event", routing_key="events.reprocessing.preprocess_event"
),
Expand Down
9 changes: 0 additions & 9 deletions src/sentry/options/defaults.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,15 +644,6 @@
flags=FLAG_PRIORITIZE_DISK | FLAG_AUTOMATOR_MODIFIABLE,
)

# The fraction of prooguard events that will be routed to the
# separate `store.process_event_proguard` queue
# TODO: Unused, remove this.
register(
"store.separate-proguard-queue-rate",
default=0.0,
flags=FLAG_AUTOMATOR_MODIFIABLE | FLAG_MODIFIABLE_RATE,
)

# Query and supply Bundle Indexes to Symbolicator SourceMap processing
register(
"symbolicator.sourcemaps-bundle-index-sample-rate", default=0.0, flags=FLAG_AUTOMATOR_MODIFIABLE
Expand Down
36 changes: 0 additions & 36 deletions src/sentry/tasks/store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,42 +459,6 @@ def process_event(
)


# TODO: Unused, remove this.
@instrumented_task(
name="sentry.tasks.store.process_event_proguard",
queue="events.process_event_proguard",
time_limit=65,
soft_time_limit=60,
silo_mode=SiloMode.REGION,
)
def process_event_proguard(
cache_key: str,
start_time: float | None = None,
event_id: str | None = None,
data_has_changed: bool = False,
from_symbolicate: bool = False,
has_attachments: bool = False,
**kwargs: Any,
) -> None:
"""
Handles event processing (for those events that need it)

:param string cache_key: the cache key for the event data
:param int start_time: the timestamp when the event was ingested
:param string event_id: the event identifier
:param boolean data_has_changed: set to True if the event data was changed in previous tasks
"""
return do_process_event(
cache_key=cache_key,
start_time=start_time,
event_id=event_id,
from_reprocessing=False,
data_has_changed=data_has_changed,
from_symbolicate=from_symbolicate,
has_attachments=has_attachments,
)


@instrumented_task(
name="sentry.tasks.store.process_event_from_reprocessing",
queue="events.reprocessing.process_event",
Expand Down
Loading