Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(proguard): Remove separate queue #74198

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

loewenheim
Copy link
Contributor

We stopped routing events to the process_event_proguard task (and therefore the events.process_event_proguard queue) in #74075. The store.separate-proguard-queue-rate option was removed from the options automator in https://github.com/getsentry/sentry-options-automator/pull/1895.

@loewenheim loewenheim requested a review from a team July 12, 2024 13:19
@loewenheim loewenheim self-assigned this Jul 12, 2024
@loewenheim loewenheim requested a review from Swatinem July 12, 2024 13:19
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.19%. Comparing base (2a0df0c) to head (0c0d977).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #74198   +/-   ##
=======================================
  Coverage   78.19%   78.19%           
=======================================
  Files        6659     6659           
  Lines      297424   297420    -4     
  Branches    51184    51183    -1     
=======================================
- Hits       232584   232582    -2     
+ Misses      58525    58523    -2     
  Partials     6315     6315           
Files Coverage Δ
src/sentry/conf/server.py 87.80% <ø> (ø)
src/sentry/options/defaults.py 100.00% <ø> (ø)
src/sentry/tasks/store.py 82.32% <ø> (+0.19%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 next step, kill the deployment, then profit

@loewenheim loewenheim merged commit 1b13e98 into master Jul 15, 2024
51 checks passed
@loewenheim loewenheim deleted the ref/proguard-remove-separate-queue branch July 15, 2024 09:28
@loewenheim loewenheim added the Trigger: Revert add to a merged PR to revert it (skips CI) label Jul 15, 2024
@loewenheim
Copy link
Contributor Author

Reverting this, the worker first needs to be removed in ops.

@getsentry-bot
Copy link
Contributor

PR reverted: a1ab12d

getsentry-bot added a commit that referenced this pull request Jul 15, 2024
@loewenheim loewenheim restored the ref/proguard-remove-separate-queue branch July 15, 2024 12:57
loewenheim added a commit that referenced this pull request Jul 15, 2024
@loewenheim loewenheim deleted the ref/proguard-remove-separate-queue branch July 15, 2024 13:33
priscilawebdev pushed a commit that referenced this pull request Jul 16, 2024
We stopped routing events to the `process_event_proguard` task (and
therefore the `events.process_event_proguard` queue) in
#74075. The
`store.separate-proguard-queue-rate` option was removed from the options
automator in
getsentry/sentry-options-automator#1895.
priscilawebdev pushed a commit that referenced this pull request Jul 16, 2024
priscilawebdev pushed a commit that referenced this pull request Jul 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants