-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(context): Address a few small context bugs #72013
Conversation
Bundle ReportChanges will decrease total bundle size by 2.2kB ⬇️
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #72013 +/- ##
===========================================
+ Coverage 56.88% 77.93% +21.05%
===========================================
Files 6564 6573 +9
Lines 292402 292626 +224
Branches 50469 50529 +60
===========================================
+ Hits 166323 228065 +61742
+ Misses 121334 58307 -63027
- Partials 4745 6254 +1509
|
ac73648
to
fd5d2df
Compare
if (hideUnknown && imageName === logoUnknown) { | ||
return null; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@malwilley This is the issue since even though we're asking for a firefox logo, this line will resolve true because the unknown logo and firefox logo both resolve to this for tests. So in this test, the logo doesn't actually render any more, meaning i can't use a test id. I also couldn't find a way to override this but if you know of a better alternative that'd be great
This reverts commit 2b965d5.
We wanted to preserve casing for unknown context from the sdk in #72013, but there are a few non-context context items that weren't accounted for. **Before** ![image](https://github.com/getsentry/sentry/assets/35509934/e97ee884-4e66-45b4-ad6e-87b4e6cb9ed8) **After** ![image](https://github.com/getsentry/sentry/assets/35509934/a12e560f-8231-49e2-bf24-5c28648b79de)
Depends on #72008 to avoid merge conflicts.
Fixes:
constructor
would return a meta of{}
becauseObject.constructor
always exists. Now it checks if that meta object is empty, rather than if it exists.todo