Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contexts): Add laravel as known platform context #72008

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

leeandher
Copy link
Member

Resolves #68082

Adds laravel as a known context. Rather than adding each SDK specific context as its own item, this will let us extend it if more come in with type: default.

image

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 4, 2024
@leeandher leeandher marked this pull request as ready for review June 4, 2024 15:29
@leeandher leeandher requested a review from a team as a code owner June 4, 2024 15:29
Copy link

codecov bot commented Jun 4, 2024

Bundle Report

Changes will increase total bundle size by 6.46kB ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 27.92MB 6.46kB ⬆️

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 42.30769% with 15 lines in your changes missing coverage. Please review.

Project coverage is 77.93%. Comparing base (36a4154) to head (bd18df6).
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #72008      +/-   ##
==========================================
- Coverage   77.94%   77.93%   -0.01%     
==========================================
  Files        6572     6573       +1     
  Lines      292600   292678      +78     
  Branches    50523    50537      +14     
==========================================
+ Hits       228056   228093      +37     
- Misses      58293    58331      +38     
- Partials     6251     6254       +3     
Files Coverage Δ
...tic/app/components/events/contexts/contextCard.tsx 75.00% <ø> (ø)
static/app/components/events/contexts/utils.tsx 51.53% <50.00%> (-0.47%) ⬇️
.../app/components/events/contexts/platform/index.tsx 38.88% <38.88%> (ø)

... and 50 files with indirect coverage changes

@leeandher leeandher merged commit 556bbaa into master Jun 4, 2024
41 of 42 checks passed
@leeandher leeandher deleted the leander/laravel-context branch June 4, 2024 17:29
leeandher added a commit that referenced this pull request Jun 4, 2024
Depends on #72008 to avoid merge
conflicts.

Fixes:
- Empty metadata no longer annotates text. E.g. context with key
`constructor` would return a meta of `{}` because `Object.constructor`
always exists. Now it checks if that meta object is empty, rather than
if it exists.
- Custom context is no longer Title-Cased or Start Cased (to retain
exactly what users send)
- Unknown browsers from showing a (?) icon in context cards
- Adds title to icons for legibility of smaller icons



![image](https://github.com/getsentry/sentry/assets/35509934/b0c35acc-168b-421e-97b9-c773e7528035)


![image](https://github.com/getsentry/sentry/assets/35509934/2b1b24f9-91cd-4479-9eb3-4e31746afe21)

**todo**
- [x] Fix any failing tests
- [x] Add a fix for icon sizing (e.g. samsung, ios devices)
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Laravel specific Context UI
2 participants