feat(crons): Implement fallback clock pulse task #54647
Conversation
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #54647 +/- ##
==========================================
- Coverage 79.78% 79.77% -0.01%
==========================================
Files 5000 5000
Lines 212248 212271 +23
Branches 36162 36164 +2
==========================================
+ Hits 169340 169348 +8
- Misses 37700 37712 +12
- Partials 5208 5211 +3
|
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-crons-implement-fallback-clock-pulse-task
branch
from
d8418ef
to
2fb5dfe
Compare
| @@ -129,6 +146,30 @@ def try_monitor_tasks_trigger(ts: datetime): | |||
| _dispatch_tasks(ts) | |||
|
|
|||
|
|
|||
| @instrumented_task(name="sentry.monitors.tasks.clock_pulse", silo_mode=SiloMode.REGION) | |||
| def clock_pulse(current_datetime=None): | |||
There was a problem hiding this comment.
Shouldn't this run conditionally based on a setting?
There was a problem hiding this comment.
No, as per fillipos comment #53661 (comment), we decided to just always have it run. Then we don't have a "high" or "low" volume mode. it is just adaptive.
There was a problem hiding this comment.
If this is running all the time then doesn't it break the case where there's an ingest backlog?
There was a problem hiding this comment.
No because it is still putting the message into the kafka topic, thus into the queue.
This would be problematic if we turned off producers (relay)
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-crons-implement-fallback-clock-pulse-task
branch
from
2fb5dfe
to
c66b615
Compare
evanpurkhiser
deleted the
evanpurkhiser/feat-crons-implement-fallback-clock-pulse-task
branch
This is the last piece of GH-53661 to ensure tasks are triggered in scenarios where there is not enough volume.