ref(crons): Move monitor dispatch code to monitors.tasks #54591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
evanpurkhiser
commented
Aug 10, 2023
| sdk: str | ||
|
|
||
|
|
||
| class ClockPulseMessage(TypedDict): |
There was a problem hiding this comment.
Will be using this type in both the tasks and consumer, don't want an import cycle so it moves here.
There was a problem hiding this comment.
don't see it in the tasks yet. future work?
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-crons-move-monitor-dispatch-code-to-monitors-tasks
branch
from
2fb0f3f
to
e780652
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #54591 +/- ##
==========================================
- Coverage 79.75% 79.74% -0.01%
==========================================
Files 4994 4996 +2
Lines 212152 212195 +43
Branches 36161 36171 +10
==========================================
+ Hits 169192 169218 +26
- Misses 37751 37770 +19
+ Partials 5209 5207 -2
|
rjo100
approved these changes
Aug 11, 2023
evanpurkhiser
deleted the
evanpurkhiser/ref-crons-move-monitor-dispatch-code-to-monitors-tasks
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.