Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(sort): Change betterPriority to priority #52910

Merged
merged 1 commit into from
Jul 17, 2023
Merged

ref(sort): Change betterPriority to priority #52910

merged 1 commit into from
Jul 17, 2023

Conversation

ceorourke
Copy link
Member

@ceorourke ceorourke commented Jul 14, 2023 •
edited
Loading

Change references to the new priority sort to just "priority" for simplicity and to prevent more saved searches being created with the sort string "betterPriority".

After this is merged we'll run a migration to make all saved searches for priority sort the same (#52909) and then finish by cleaning up the backend to only accept "priority" (right now it treats betterPriority and priority the same".

Step 1: This PR
Step 2: Migration #52909
Step 3: Backend PR #52915

@ceorourke ceorourke requested a review from a team as a code owner July 14, 2023 19:59
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 14, 2023
@ceorourke ceorourke mentioned this pull request Jul 14, 2023
Merged
@ceorourke ceorourke mentioned this pull request Jul 14, 2023
Merged
@ceorourke ceorourke merged commit 316f77a into master Jul 17, 2023
@ceorourke ceorourke deleted the ceorourke/fe-priority-swaparoo branch July 17, 2023 21:11
ceorourke added a commit that referenced this pull request Jul 17, 2023
@ceorourke
ref(saved search): Migrate betterPriority to priority (#52909)
f243492 
Now that we've GA'd the new priority sort, we should clean up the saved
searches that were made with the sort "betterPriority".

Step 1: Front end PR to stop saving searches w/ betterPriority
#52910
Step 2: This PR
Step 3: Backend PR #52915
ceorourke added a commit that referenced this pull request Jul 17, 2023
@ceorourke
ref(sort): Replace betterPriority with priority (#52915)
91ef3f0 
Now that the betterPriority sort is out and has replaced the old
priority, just rename everything to priority for simplicity.

Step 1: FE PR: #52910
Step 2: Migration: #52909
Step 3: This PR!
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@malwilley malwilley malwilley approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ceorourke @malwilley