ref(saved search): Migrate betterPriority to priority #52909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
|
This PR has a migration; here is the generated SQL for --
-- MIGRATION NOW PERFORMS OPERATION THAT CANNOT BE WRITTEN AS SQL:
-- Raw Python operation
-- |
This was referenced Jul 14, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52909 +/- ##
=======================================
Coverage 79.37% 79.37%
=======================================
Files 4932 4934 +2
Lines 207130 207222 +92
Branches 35392 35405 +13
=======================================
+ Hits 164407 164489 +82
- Misses 37691 37701 +10
Partials 5032 5032
|
wedamija
approved these changes
Jul 17, 2023
ceorourke
added a commit
that referenced
this pull request
Jul 17, 2023
Change references to the new priority sort to just "priority" for simplicity and to prevent more saved searches being created with the sort string "betterPriority". After this is merged we'll run a migration to make all saved searches for priority sort the same (#52909) and then finish by cleaning up the backend to only accept "priority" (right now it treats betterPriority and priority the same". Step 1: This PR Step 2: Migration #52909 Step 3: Backend PR #52915
ceorourke
added a commit
that referenced
this pull request
Jul 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we've GA'd the new priority sort, we should clean up the saved searches that were made with the sort "betterPriority".
Step 1: Front end PR to stop saving searches w/ betterPriority #52910
Step 2: This PR
Step 3: Backend PR #52915