Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(escalating-issues): Add new use case for metrics dataset #52360

Merged
merged 1 commit into from
Jul 13, 2023
Merged

feat(escalating-issues): Add new use case for metrics dataset #52360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/sentry/sentry_metrics/use_case_id_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,15 @@ class UseCaseID(Enum):
SPANS = "spans"
TRANSACTIONS = "transactions"
SESSIONS = "sessions"
ESCALATING_ISSUES = "escalating_issues"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayirr7 hmm do you think this dataset would be reused by others or its just this feature?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this is the list of all existing use cases - others could hypothetically use the escalating_issues use case and send metrics onto it



# UseCaseKey will be renamed to MetricPathKey
METRIC_PATH_MAPPING: Mapping[UseCaseID, UseCaseKey] = {
UseCaseID.SPANS: UseCaseKey.PERFORMANCE,
UseCaseID.TRANSACTIONS: UseCaseKey.PERFORMANCE,
UseCaseID.SESSIONS: UseCaseKey.RELEASE_HEALTH,
UseCaseID.ESCALATING_ISSUES: UseCaseKey.PERFORMANCE,
}

# TODO: Remove this as soon as the entire indexer system is use case aware
Expand Down