feat(escalating-issues): Add new use case for metrics dataset #52360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
snigdhas
force-pushed
the
snigdha/metrics-backend
branch
from
11a8712
to
79a1d9a
Compare
| @@ -10,13 +10,15 @@ class UseCaseID(Enum): | |||
| SPANS = "spans" | |||
| TRANSACTIONS = "transactions" | |||
| SESSIONS = "sessions" | |||
| ESCALATING_ISSUES = "escalating_issues" | |||
There was a problem hiding this comment.
@ayirr7 hmm do you think this dataset would be reused by others or its just this feature?
There was a problem hiding this comment.
so this is the list of all existing use cases - others could hypothetically use the escalating_issues use case and send metrics onto it
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52360 +/- ##
========================================
Coverage 79.31% 79.31%
========================================
Files 4900 4909 +9
Lines 205043 205773 +730
Branches 35048 35168 +120
========================================
+ Hits 162625 163219 +594
- Misses 37457 37564 +107
- Partials 4961 4990 +29
|
|
Overall these changes look good to me, I'd recommend going through the local testing flow I described offline as well. I can approve after that goes through! |
|
Discussed offline that local testing was successful |
ayirr7
approved these changes
Jul 11, 2023
michellewzhang
pushed a commit
that referenced
this pull request
Jul 13, 2023
Register a new use case for the metrics dataset to be used with escalating issues.
mifu67
pushed a commit
that referenced
this pull request
Jul 13, 2023
Register a new use case for the metrics dataset to be used with escalating issues.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register a new use case for the metrics dataset to be used with escalating issues.