feat(grouping): Upgrade projects to the latest grouping configuration #51040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Customers that have auto-update disabled will not be updated. The [2023-01-11](https://github.com/getsentry/sentry/blob/42a860c4fd13672cb3fa3384ede490654de44e0f/src/sentry/grouping/strategies/configurations.py#L189-L202) group config has the following changes: * A Java grouping fix: [java_cglib_hibernate_logic](#45185) * [A bunch of stacktrace enhancers](https://github.com/getsentry/sentry/blob/master/src/sentry/grouping/enhancer/enhancement-configs/newstyle%402023-01-11.txt) (based on the mobile enhancers) * More info in section 2 From: #45185 behind the `java_cglib_hibernate_logic` branch: Do not consider these as inApp: - `$EnhancerBy...$` - `$FastClassBy...$` - `$HibernateProxy$` Fixes getsentry/sentry-java#1018 [The file](https://github.com/getsentry/sentry/blob/master/src/sentry/grouping/enhancer/enhancement-configs/newstyle%402023-01-11.txt) has a bunch of enhancers. You can review the `pynsap` changes in the PR to get a sense of the changes. This is based off [the mobile enhancers file](https://github.com/getsentry/sentry/blob/master/src/sentry/grouping/enhancer/enhancement-configs/[email protected]). It basically adds the following [extra rules](https://github.com/getsentry/sentry/blob/8ef3e68d626d06859960a630a46296d52a9b93dc/src/sentry/grouping/enhancer/enhancement-configs/newstyle%402023-01-11.txt#L404-L463). All the PRs listed below are also part of [this milestone](https://github.com/getsentry/sentry/milestone/50?closed=1). The enhancements on top of the mobile enhancers includes these PRs (from [this historical view](https://github.com/getsentry/sentry/commits/master/src/sentry/grouping/enhancer/enhancement-configs/newstyle%402023-01-11.txt)): * #45423 * #44761 The changes for the mobile enhancers can be seen [here](https://github.com/getsentry/sentry/commits/master/src/sentry/grouping/enhancer/enhancement-configs/mobile%402021-04-02.txt): * #28669 * #28069 * #27994 * #27880 * #27836 * #27744 * #27781 * #27754 * #27314 * #27239 * #27076 * #27197
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51040 +/- ##
==========================================
+ Coverage 79.56% 81.24% +1.67%
==========================================
Files 4886 4889 +3
Lines 204812 204913 +101
Branches 11127 11127
==========================================
+ Hits 162965 166487 +3522
+ Misses 41601 38180 -3421
Partials 246 246
|
jjbayer
approved these changes
Jun 19, 2023
17hogeju
pushed a commit
that referenced
this pull request
Jun 20, 2023
…#51040) This PR upgrades all projects that do not have auto-update disabled to the 2023-01-11 grouping config. This will happen as events for the project happen. Customers that want to override [any of the values from the enhancers in this release](https://github.com/getsentry/sentry/blob/master/src/sentry/grouping/enhancer/enhancement-configs/newstyle%402023-01-11.txt) can do so by using the project's [Stack Trace Rules under Issue Grouping](https://docs.sentry.io/product/data-management-settings/event-grouping/stack-trace-rules/). <img width="829" alt="image" src="https://github.com/getsentry/sentry/assets/44410/fd06e3d3-8f7b-438d-9a96-8431aa511a0f"> For instance, this change: `family:native package:/lib/** -app` can be overwritten with: `family:native package:/lib/** +app` ### Changes in this release The [2023-01-11](https://github.com/getsentry/sentry/blob/42a860c4fd13672cb3fa3384ede490654de44e0f/src/sentry/grouping/strategies/configurations.py#L189-L202) group config has the following changes: * A Java grouping fix: [java_cglib_hibernate_logic](#45185) * [A bunch of stacktrace enhancers](https://github.com/getsentry/sentry/blob/master/src/sentry/grouping/enhancer/enhancement-configs/newstyle%402023-01-11.txt) (based on the mobile enhancers) * More info in section 2 #### Java change From: #45185 behind the `java_cglib_hibernate_logic` branch: Do not consider these as inApp: - `$EnhancerBy...$` - `$FastClassBy...$` - `$HibernateProxy$` Fixes getsentry/sentry-java#1018 #### Stack Trace Rules Enhancers [The file](https://github.com/getsentry/sentry/blob/master/src/sentry/grouping/enhancer/enhancement-configs/newstyle%402023-01-11.txt) has a bunch of enhancers. You can review the `pynsap` changes in the PR to get a sense of the changes. This is based off [the mobile enhancers file](https://github.com/getsentry/sentry/blob/master/src/sentry/grouping/enhancer/enhancement-configs/[email protected]). It basically adds the following [extra rules](https://github.com/getsentry/sentry/blob/8ef3e68d626d06859960a630a46296d52a9b93dc/src/sentry/grouping/enhancer/enhancement-configs/newstyle%402023-01-11.txt#L404-L463). All the PRs listed below are also part of [this milestone](https://github.com/getsentry/sentry/milestone/50?closed=1). The enhancements on top of the mobile enhancers includes these PRs (from [this historical view](https://github.com/getsentry/sentry/commits/master/src/sentry/grouping/enhancer/enhancement-configs/newstyle%402023-01-11.txt)): * #45423 * #44761 The changes for the mobile enhancers can be seen [here](https://github.com/getsentry/sentry/commits/master/src/sentry/grouping/enhancer/enhancement-configs/mobile%402021-04-02.txt): * #28669 * #28069 * #27994 * #27880 * #27836 * #27744 * #27781 * #27754 * #27314 * #27239 * #27076 * #27197 --------- Co-authored-by: Armen Zambrano G <[email protected]> Co-authored-by: Arpad Borsos <[email protected]>
armenzg
modified the milestones:
Grouping Release (2023-01-01 config),
save_event improvements work
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades all projects that do not have auto-update disabled to the 2023-01-11 grouping config. This will happen as events for the project happen.
Customers that want to override any of the values from the enhancers in this release can do so by using the project's Stack Trace Rules under Issue Grouping.
For instance, this change:
family:native package:/lib/** -appcan be overwritten with:
family:native package:/lib/** +appChanges in this release
The 2023-01-11 group config has the following changes:
Java change
From: #45185 behind the
java_cglib_hibernate_logicbranch:Do not consider these as inApp:
$EnhancerBy...$$FastClassBy...$$HibernateProxy$Fixes getsentry/sentry-java#1018
Stack Trace Rules Enhancers
The file has a bunch of enhancers. You can review the
pynsapchanges in the PR to get a sense of the changes.This is based off the mobile enhancers file. It basically adds the following extra rules.
All the PRs listed below are also part of this milestone.
The enhancements on top of the mobile enhancers includes these PRs (from this historical view):
The changes for the mobile enhancers can be seen here: