fix(grouping): Revert overreaching threadbase->std rule #27994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove a rule that said system frames close to the threadbase can be ignored. This caused us to throw away the entire stacktrace and group by exc value only, in test regression_threadbase_and_system. In compensation, categorize a lot more threadbases which is what we were trying to avoid with that rule.
jan-auer
approved these changes
Aug 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a rule that said system frames close to the threadbase can be
ignored. This caused us to throw away the entire stacktrace and group by
exc value only, in test regression_threadbase_and_system.
In compensation, categorize a lot more threadbases which is what we were
trying to avoid with that rule.
Delete some more testcases because the test system said they were covered by the new regression test