Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(grouping): Revert overreaching threadbase->std rule #27994

Merged
merged 2 commits into from
Aug 9, 2021
Merged

fix(grouping): Revert overreaching threadbase->std rule #27994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc11904
fix(grouping): Revert overreaching threadbase->std rule
untitaker Aug 6, 2021
6dbc5bd
update grouping snapshots
untitaker Aug 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/sentry/grouping/enhancer/enhancement-configs/[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,13 @@ module:java.util.concurrent.ThreadPoolExecutor* function:runWorker category=thre
module:android.os.* function:call category=threadbase
module:android.app.ActivityThread function:main category=threadbase
module:android.view.View function:layout category=threadbase
module:android.os.Looper function:loop category=threadbase
family:native function:TppWorkerThread category=threadbase
family:native function:TppWorkpExecuteCallback category=threadbase
family:native function:RtlpTpWorkCallback category=threadbase
module:android.os.Handler function:dispatchMessage category=threadbase
module:android.os.Handler function:handleCallback category=threadbase
module:android.app.ActivityThread* function:handleMessage category=threadbase

family:native package:"**/libsystem_malloc.dylib" category=malloc
family:native function:malloc category=malloc
Expand Down Expand Up @@ -389,5 +396,3 @@ family:native function:*.cold.1 category=indirection
[ category:runtime ] | category:system category=internals
[ category:runtime ] | category:runtime category=internals
[ category:dtor ] | category:dtor category=internals
[ category:threadbase ] | category:system category=internals
[ category:threadbase ] | category:std category=internals
107 changes: 0 additions & 107 deletions tests/sentry/grouping/categorization_inputs/mobile1-xhy.json
View file
Open in desktop

This file was deleted.

83 changes: 0 additions & 83 deletions tests/sentry/grouping/categorization_inputs/mobile1-xrx.json
View file
Open in desktop

This file was deleted.

60 changes: 60 additions & 0 deletions tests/sentry/grouping/categorization_inputs/regression-threadbase-and-system.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
{
"event_id": "b3f3459f9c964e97bb0d168583e97053",
"exception": {
"values": [
{
"mechanism": {
"handled": false,
"meta": {
"signal": {
"name": "SIGSEGV",
"number": 11
}
},
"synthetic": true,
"type": "signalhandler"
},
"stacktrace": {
"frames": [
{
"function": "__start_thread",
"package": "/system/lib/libc.so"
},
{
"function": "__pthread_start",
"package": "/system/lib/libc.so",
"raw_function": "__pthread_start(void*)"
},
{
"function": "art::ThreadPoolWorker::Callback",
"package": "/system/lib/libart.so",
"raw_function": "art::ThreadPoolWorker::Callback(void*)"
},
{
"function": "art::ThreadPoolWorker::Run",
"package": "/system/lib/libart.so",
"raw_function": "art::ThreadPoolWorker::Run()"
},
{
"function": "art::ThreadPool::GetTask",
"package": "/system/lib/libart.so",
"raw_function": "art::ThreadPool::GetTask(art::Thread*)"
},
{
"function": "art::ConditionVariable::WaitHoldingLocks",
"package": "/system/lib/libart.so",
"raw_function": "art::ConditionVariable::WaitHoldingLocks(art::Thread*)"
},
{
"function": "syscall",
"package": "/system/lib/libc.so"
}
]
},
"type": "SIGSEGV",
"value": "Segfault"
}
]
},
"platform": "native"
}
8 changes: 4 additions & 4 deletions tests/sentry/grouping/snapshots/test_categorization/test_categorization/android_anr2.pysnap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
created: '2021-08-03T17:17:27.405665Z'
created: '2021-08-06T16:25:44.936147Z'
creator: sentry
source: tests/sentry/grouping/test_categorization.py
---
Expand All @@ -10,9 +10,9 @@ ApplicationNotResponding:Application Not Responding for at least 5000 ms. (threa
com.android.internal.os.ZygoteInit$MethodA run category=internals
java.lang.reflect.Method invoke category=indirection
android.app.ActivityThread main category=threadbase
android.os.Looper loop category=internals
android.os.Handler dispatchMessage category=internals
android.os.Handler handleCallback category=internals
android.os.Looper loop category=threadbase
android.os.Handler dispatchMessage category=threadbase
android.os.Handler handleCallback category=threadbase
android.view.Choreographer$FrameDisplayEve run category=indirection
android.view.Choreographer doFrame category=ui
android.view.Choreographer doCallbacks category=internals
Expand Down
8 changes: 4 additions & 4 deletions ...try/grouping/snapshots/test_categorization/test_categorization/group_200_event_200.pysnap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
created: '2021-08-03T15:05:54.212999Z'
created: '2021-08-06T16:25:45.195581Z'
creator: sentry
source: tests/sentry/grouping/test_categorization.py
---
Expand All @@ -8,9 +8,9 @@ source: tests/sentry/grouping/test_categorization.py
EXCEPTION_ACCESS_VIOLATION_WRITE:Fatal Error: EXCEPTION_ACCESS_VIOLATION_WRITE (thread_id:_, crashed:_)
C:\WINDOWS\SYSTEM32\ntdll.dll RtlUserThreadStart category=threadbase
C:\WINDOWS\System32\KERNEL32.DLL BaseThreadInitThunk category=threadbase
C:\WINDOWS\SYSTEM32\ntdll.dll TppWorkerThread category=internals
C:\WINDOWS\SYSTEM32\ntdll.dll TppWorkpExecuteCallback category=internals
C:\WINDOWS\SYSTEM32\WINHTTP.dll HTTP_THREAD_POOL::_StaticWorkItemCallback category=internals
C:\WINDOWS\SYSTEM32\ntdll.dll TppWorkerThread category=threadbase
C:\WINDOWS\SYSTEM32\ntdll.dll TppWorkpExecuteCallback category=threadbase
C:\WINDOWS\SYSTEM32\WINHTTP.dll HTTP_THREAD_POOL::_StaticWorkItemCallback category=system
C:\WINDOWS\SYSTEM32\WINHTTP.dll HTTP_ASYNC_OVERLAPPED::OnWorkItem category=internals
C:\WINDOWS\SYSTEM32\WINHTTP.dll WEBIO_REQUEST::OnIoComplete category=internals
C:\WINDOWS\SYSTEM32\WINHTTP.dll HTTP_USER_REQUEST::OnSendRequest category=internals
Expand Down
6 changes: 3 additions & 3 deletions ...try/grouping/snapshots/test_categorization/test_categorization/group_432_event_432.pysnap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
created: '2021-08-03T15:05:52.084020Z'
created: '2021-08-06T16:30:59.415109Z'
creator: sentry
source: tests/sentry/grouping/test_categorization.py
---
Expand All @@ -8,8 +8,8 @@ source: tests/sentry/grouping/test_categorization.py
0x40000015 / 0x00000001:Fatal Error: 0x40000015 / 0x00000001 (thread_id:_, crashed:_)
C:\WINDOWS\SYSTEM32\ntdll.dll RtlUserThreadStart category=threadbase
C:\WINDOWS\System32\KERNEL32.DLL BaseThreadInitThunk category=threadbase
C:\WINDOWS\SYSTEM32\ntdll.dll TppWorkerThread category=internals
C:\WINDOWS\SYSTEM32\ntdll.dll RtlpTpWorkCallback category=internals
C:\WINDOWS\SYSTEM32\ntdll.dll TppWorkerThread category=threadbase
C:\WINDOWS\SYSTEM32\ntdll.dll RtlpTpWorkCallback category=threadbase
stripped_application_code
stripped_application_code
stripped_application_code
Expand Down
6 changes: 3 additions & 3 deletions ...try/grouping/snapshots/test_categorization/test_categorization/group_432_event_453.pysnap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
created: '2021-08-03T15:05:51.810683Z'
created: '2021-08-06T16:30:59.491005Z'
creator: sentry
source: tests/sentry/grouping/test_categorization.py
---
Expand All @@ -8,8 +8,8 @@ source: tests/sentry/grouping/test_categorization.py
0x40000015 / 0x00000001:Fatal Error: 0x40000015 / 0x00000001 (thread_id:_, crashed:_)
C:\windows\SYSTEM32\ntdll.dll RtlUserThreadStart category=threadbase
C:\windows\System32\KERNEL32.DLL BaseThreadInitThunk category=threadbase
C:\windows\SYSTEM32\ntdll.dll TppWorkerThread category=internals
C:\windows\SYSTEM32\ntdll.dll RtlpTpWorkCallback category=internals
C:\windows\SYSTEM32\ntdll.dll TppWorkerThread category=threadbase
C:\windows\SYSTEM32\ntdll.dll RtlpTpWorkCallback category=threadbase
stripped_application_code
stripped_application_code
stripped_application_code
Expand Down
4 changes: 2 additions & 2 deletions ...try/grouping/snapshots/test_categorization/test_categorization/group_445_event_445.pysnap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
created: '2021-08-03T15:05:49.744595Z'
created: '2021-08-06T16:16:56.757525Z'
creator: sentry
source: tests/sentry/grouping/test_categorization.py
---
Expand All @@ -11,7 +11,7 @@ source: tests/sentry/grouping/test_categorization.py
stripped_application_code
exe_common.inl invoke_main category=threadbase
WinMain.cpp wWinMain category=threadbase
xstring std::basic_string<T>::{ctor} category=internals
xstring std::basic_string<T>::{ctor} category=std
xstring std::basic_string<T>::assign category=internals
xstring std::basic_string<T>::assign category=internals
xstring std::basic_string<T>::_Reallocate_for category=internals
Expand Down
Loading