-
-
Notifications
You must be signed in to change notification settings - Fork 355
chore(deps): update JavaScript SDK to v8.37.1 #4236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eb7e726 to
2f81f83
Compare
Contributor
Author
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e540498+dirty | 408.56 ms | 480.00 ms | 71.44 ms |
| 1faf8e3+dirty | 412.83 ms | 470.49 ms | 57.66 ms |
| dadc233+dirty | 363.19 ms | 370.37 ms | 7.18 ms |
| d197b5c+dirty | 258.75 ms | 313.61 ms | 54.86 ms |
| c2a4e9b+dirty | 392.94 ms | 474.55 ms | 81.61 ms |
| d7401ac+dirty | 373.98 ms | 394.08 ms | 20.10 ms |
| e5c9b8b+dirty | 335.40 ms | 360.06 ms | 24.67 ms |
| 8900e1a+dirty | 371.40 ms | 377.70 ms | 6.31 ms |
| 484813b+dirty | 411.65 ms | 456.02 ms | 44.37 ms |
| fe13591+dirty | 539.51 ms | 597.92 ms | 58.40 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e540498+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| 1faf8e3+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| dadc233+dirty | 7.15 MiB | 8.04 MiB | 910.84 KiB |
| d197b5c+dirty | 7.15 MiB | 8.09 MiB | 962.72 KiB |
| c2a4e9b+dirty | 7.15 MiB | 8.34 MiB | 1.19 MiB |
| d7401ac+dirty | 7.15 MiB | 8.04 MiB | 910.85 KiB |
| e5c9b8b+dirty | 7.15 MiB | 8.10 MiB | 980.41 KiB |
| 8900e1a+dirty | 7.15 MiB | 8.03 MiB | 901.79 KiB |
| 484813b+dirty | 7.15 MiB | 8.34 MiB | 1.19 MiB |
| fe13591+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
Previous results on branch: deps/scripts/update-javascript.sh
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c0332a6+dirty | 389.21 ms | 449.39 ms | 60.17 ms |
| cdeca8b+dirty | 418.09 ms | 468.62 ms | 50.53 ms |
| e4c23be+dirty | 379.09 ms | 412.68 ms | 33.59 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c0332a6+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| cdeca8b+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| e4c23be+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
Contributor
Author
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 52c0562+dirty | 1219.34 ms | 1221.25 ms | 1.91 ms |
| 0677344+dirty | 1276.70 ms | 1300.07 ms | 23.37 ms |
| 0d3e677+dirty | 1214.39 ms | 1225.70 ms | 11.31 ms |
| 1d86dd6+dirty | 1249.71 ms | 1279.16 ms | 29.45 ms |
| 70e6261+dirty | 1220.09 ms | 1230.04 ms | 9.95 ms |
| 9a3ca65+dirty | 1247.06 ms | 1274.58 ms | 27.52 ms |
| ad6c299+dirty | 1244.76 ms | 1260.10 ms | 15.34 ms |
| 34aba08+dirty | 1276.78 ms | 1308.52 ms | 31.74 ms |
| 80b2ce3+dirty | 1265.92 ms | 1268.60 ms | 2.69 ms |
| d43a46b+dirty | 1219.24 ms | 1219.65 ms | 0.41 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 52c0562+dirty | 2.36 MiB | 3.14 MiB | 793.36 KiB |
| 0677344+dirty | 2.36 MiB | 2.85 MiB | 496.81 KiB |
| 0d3e677+dirty | 2.36 MiB | 3.10 MiB | 753.12 KiB |
| 1d86dd6+dirty | 2.36 MiB | 2.89 MiB | 535.43 KiB |
| 70e6261+dirty | 2.36 MiB | 3.03 MiB | 680.42 KiB |
| 9a3ca65+dirty | 2.36 MiB | 2.82 MiB | 462.89 KiB |
| ad6c299+dirty | 2.36 MiB | 2.84 MiB | 488.85 KiB |
| 34aba08+dirty | 2.36 MiB | 2.85 MiB | 495.32 KiB |
| 80b2ce3+dirty | 2.36 MiB | 2.84 MiB | 486.98 KiB |
| d43a46b+dirty | 2.36 MiB | 3.08 MiB | 734.25 KiB |
Previous results on branch: deps/scripts/update-javascript.sh
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| cdeca8b+dirty | 1212.42 ms | 1223.69 ms | 11.27 ms |
| e4c23be+dirty | 1225.25 ms | 1223.76 ms | -1.49 ms |
| c0332a6+dirty | 1223.13 ms | 1232.31 ms | 9.18 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| cdeca8b+dirty | 2.36 MiB | 3.09 MiB | 743.02 KiB |
| e4c23be+dirty | 2.36 MiB | 3.08 MiB | 737.17 KiB |
| c0332a6+dirty | 2.36 MiB | 3.08 MiB | 736.57 KiB |
2f81f83 to
4dcc8d4
Compare
Contributor
Author
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 52c0562+dirty | 1233.94 ms | 1226.29 ms | -7.65 ms |
| 0677344+dirty | 1252.52 ms | 1254.08 ms | 1.56 ms |
| 0d3e677+dirty | 1239.02 ms | 1241.22 ms | 2.20 ms |
| 1d86dd6+dirty | 1289.25 ms | 1293.36 ms | 4.11 ms |
| 70e6261+dirty | 1224.90 ms | 1231.02 ms | 6.12 ms |
| 9a3ca65+dirty | 1276.40 ms | 1279.14 ms | 2.74 ms |
| ad6c299+dirty | 1248.50 ms | 1248.88 ms | 0.38 ms |
| 34aba08+dirty | 1268.58 ms | 1276.80 ms | 8.22 ms |
| 80b2ce3+dirty | 1245.12 ms | 1262.04 ms | 16.92 ms |
| d43a46b+dirty | 1223.31 ms | 1230.92 ms | 7.61 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 52c0562+dirty | 2.92 MiB | 3.69 MiB | 794.15 KiB |
| 0677344+dirty | 2.92 MiB | 3.41 MiB | 500.94 KiB |
| 0d3e677+dirty | 2.92 MiB | 3.66 MiB | 758.42 KiB |
| 1d86dd6+dirty | 2.92 MiB | 3.44 MiB | 538.27 KiB |
| 70e6261+dirty | 2.92 MiB | 3.59 MiB | 686.11 KiB |
| 9a3ca65+dirty | 2.92 MiB | 3.37 MiB | 464.32 KiB |
| ad6c299+dirty | 2.92 MiB | 3.40 MiB | 494.12 KiB |
| 34aba08+dirty | 2.92 MiB | 3.41 MiB | 499.03 KiB |
| 80b2ce3+dirty | 2.92 MiB | 3.40 MiB | 492.75 KiB |
| d43a46b+dirty | 2.92 MiB | 3.64 MiB | 740.29 KiB |
Previous results on branch: deps/scripts/update-javascript.sh
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| cdeca8b+dirty | 1235.78 ms | 1225.23 ms | -10.55 ms |
| e4c23be+dirty | 1232.21 ms | 1230.16 ms | -2.05 ms |
| c0332a6+dirty | 1227.13 ms | 1230.90 ms | 3.77 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| cdeca8b+dirty | 2.92 MiB | 3.64 MiB | 744.52 KiB |
| e4c23be+dirty | 2.92 MiB | 3.64 MiB | 742.98 KiB |
| c0332a6+dirty | 2.92 MiB | 3.64 MiB | 742.47 KiB |
Contributor
Author
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dadc233+dirty | 333.78 ms | 343.94 ms | 10.16 ms |
| ad6c299 | 375.94 ms | 382.02 ms | 6.08 ms |
| 457e29f | 398.10 ms | 421.39 ms | 23.29 ms |
| d197b5c+dirty | 338.94 ms | 354.87 ms | 15.93 ms |
| 6e8584e | 447.10 ms | 474.71 ms | 27.61 ms |
| 9433f35 | 347.64 ms | 356.22 ms | 8.58 ms |
| e5bc97b | 438.96 ms | 437.39 ms | -1.57 ms |
| d7401ac+dirty | 375.20 ms | 383.51 ms | 8.31 ms |
| 2534337 | 394.15 ms | 415.12 ms | 20.97 ms |
| 4a6664f | 548.79 ms | 585.00 ms | 36.21 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dadc233+dirty | 17.73 MiB | 19.75 MiB | 2.02 MiB |
| ad6c299 | 17.73 MiB | 19.75 MiB | 2.02 MiB |
| 457e29f | 17.73 MiB | 19.84 MiB | 2.10 MiB |
| d197b5c+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
| 6e8584e | 17.73 MiB | 19.86 MiB | 2.12 MiB |
| 9433f35 | 17.73 MiB | 19.81 MiB | 2.08 MiB |
| e5bc97b | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| d7401ac+dirty | 17.73 MiB | 19.75 MiB | 2.02 MiB |
| 2534337 | 17.73 MiB | 19.84 MiB | 2.11 MiB |
| 4a6664f | 17.73 MiB | 19.94 MiB | 2.21 MiB |
Previous results on branch: deps/scripts/update-javascript.sh
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| cdeca8b | 438.11 ms | 436.48 ms | -1.63 ms |
| c0332a6 | 461.40 ms | 456.00 ms | -5.40 ms |
| e4c23be | 452.76 ms | 438.16 ms | -14.60 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| cdeca8b | 17.74 MiB | 20.07 MiB | 2.34 MiB |
| c0332a6 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| e4c23be | 17.74 MiB | 20.08 MiB | 2.34 MiB |
antonis
approved these changes
Nov 7, 2024
Contributor
antonis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I've opened an issue for the deprecated metrics API #4242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps scripts/update-javascript.sh from 8.36.0 to 8.37.1.
Auto-generated by a dependency updater.
Changelog
8.37.1
8.37.0
Important Changes
piniaIntegration(#14138)The Nuxt SDK now allows you to track Pinia state for captured errors. To enable the Pinia plugin, add the
piniaIntegrationto your client config:The Sentry Metrics beta has ended in favour of revisiting metrics in another form at a later date.
This new approach will include different APIs, making the current metrics API unnecessary. This release
deprecates the metrics API with the plan to remove in the next SDK major version. If you currently use the
metrics API in your code, you can safely continue to do so but sent data will no longer be processed by Sentry.
Learn more about the end of the Metrics beta.
Other Changes
http.response_delivery_typeattribute to resource spans (#14056)skipBrowserExtensionCheckescape hatch option (#14147)asyncFunctionReExportsto define re-exported server functions (#14104)piniaIntegration(#14138)maybeInstrument(#14140)modulesIntegrationdoes not crash esm apps (#14169)Work in this release was contributed by rexxars. Thank you for your contribution!