Skip to content

Commit

Permalink
feat(android): Use android.namespace for AGP 8 and RN 0.73 (#3133)
Browse files Browse the repository at this point in the history
Co-authored-by: Peter Lazar <[email protected]>
Co-authored-by: Kryštof Woldřich <[email protected]>
  • Loading branch information
3 people authored Jun 26, 2023
1 parent f93cfbe commit 0677344
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Features

- Use `android.namespace` for AGP 8 and RN 0.73 ([#3133](https://github.com/getsentry/sentry-react-native/pull/3133))

### Dependencies

- Bump JavaScript SDK from v7.54.0 to v7.56.0 ([#3119](https://github.com/getsentry/sentry-react-native/pull/3119))
Expand Down
5 changes: 5 additions & 0 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ if (isNewArchitectureEnabled()) {
android {
compileSdkVersion safeExtGet('compileSdkVersion', 31)

// Conditional for compatibility with AGP <4.2.
if (project.android.hasProperty("namespace")) {
namespace = "io.sentry.react"

This comment has been minimized.

Copy link
@anurag-hugo

anurag-hugo Jul 10, 2023

hey @krystofwoldrich. We have upgraded our react-native version and sentry started throwing an error during the Android app build because of the missing namespace. When is the next release planned?
Thank you.

}

defaultConfig {
minSdkVersion safeExtGet('minSdkVersion', 21)
targetSdkVersion safeExtGet('targetSdkVersion', 31)
Expand Down

0 comments on commit 0677344

Please sign in to comment.