ref(e2e): Fetch received event in the tested app #4209

krystofwoldrich · 2024-10-28T07:50:50Z

📢 Type of change

Enhancement

📜 Description

This PR prepares E2E test for switch to Maestro.

Where it's better to fetch the event in the simulator, as maestro test are declarative.

💚 How did you test it?

ci, run locally

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

#skip-changelog

github-actions · 2024-10-28T08:18:34Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	505.20 ms	498.53 ms	-6.67 ms
Size	17.74 MiB	20.08 MiB	2.34 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`3853f43`	329.68 ms	346.32 ms	16.64 ms
`e73d82f`	475.82 ms	506.55 ms	30.73 ms
`70e6261`	482.65 ms	495.70 ms	13.05 ms
`76d1baf`+dirty	335.72 ms	355.52 ms	19.80 ms
`abb7058`	370.27 ms	389.58 ms	19.31 ms
`52a8031`+dirty	311.55 ms	321.37 ms	9.82 ms
`2ec71da`	438.14 ms	460.46 ms	22.32 ms
`acadc0f`+dirty	373.24 ms	381.51 ms	8.27 ms
`d43a46b`	454.22 ms	477.79 ms	23.57 ms
`5571a20`	410.55 ms	441.06 ms	30.51 ms

App size

Revision	Plain	With Sentry	Diff
`3853f43`	17.73 MiB	19.81 MiB	2.08 MiB
`e73d82f`	17.73 MiB	20.07 MiB	2.33 MiB
`70e6261`	17.73 MiB	19.94 MiB	2.21 MiB
`76d1baf`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`abb7058`	17.73 MiB	19.83 MiB	2.10 MiB
`52a8031`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`2ec71da`	17.73 MiB	20.10 MiB	2.37 MiB
`acadc0f`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`d43a46b`	17.73 MiB	20.06 MiB	2.33 MiB
`5571a20`	17.73 MiB	19.93 MiB	2.19 MiB

github-actions · 2024-10-28T08:32:31Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1227.86 ms	1226.04 ms	-1.81 ms
Size	2.36 MiB	3.10 MiB	753.09 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`9c48b2c`+dirty	1246.96 ms	1255.73 ms	8.77 ms
`3853f43`+dirty	1221.82 ms	1242.64 ms	20.82 ms
`70e6261`+dirty	1220.09 ms	1230.04 ms	9.95 ms
`1d86dd6`+dirty	1249.71 ms	1279.16 ms	29.45 ms
`c398f67`+dirty	1219.67 ms	1225.66 ms	5.99 ms
`5bb8d5f`+dirty	1235.47 ms	1237.39 ms	1.92 ms
`d0bf494`+dirty	1289.40 ms	1298.40 ms	9.00 ms
`0d3e677`+dirty	1214.39 ms	1225.70 ms	11.31 ms
`0677344`+dirty	1276.70 ms	1300.07 ms	23.37 ms
`3ffcddd`+dirty	1244.47 ms	1264.14 ms	19.67 ms

App size

Revision	Plain	With Sentry	Diff
`9c48b2c`+dirty	2.36 MiB	2.85 MiB	495.77 KiB
`3853f43`+dirty	2.36 MiB	2.85 MiB	499.81 KiB
`70e6261`+dirty	2.36 MiB	3.03 MiB	680.42 KiB
`1d86dd6`+dirty	2.36 MiB	2.89 MiB	535.43 KiB
`c398f67`+dirty	2.36 MiB	3.04 MiB	696.27 KiB
`5bb8d5f`+dirty	2.36 MiB	2.92 MiB	570.22 KiB
`d0bf494`+dirty	2.36 MiB	2.83 MiB	481.15 KiB
`0d3e677`+dirty	2.36 MiB	3.10 MiB	753.12 KiB
`0677344`+dirty	2.36 MiB	2.85 MiB	496.81 KiB
`3ffcddd`+dirty	2.36 MiB	2.84 MiB	489.60 KiB

github-actions · 2024-10-28T08:34:24Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	440.16 ms	456.94 ms	16.78 ms
Size	7.15 MiB	8.35 MiB	1.20 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`e540498`+dirty	408.56 ms	480.00 ms	71.44 ms
`8ae23a7`+dirty	398.10 ms	411.48 ms	13.38 ms
`12427f4`+dirty	379.48 ms	400.92 ms	21.44 ms
`80b2ce3`+dirty	271.29 ms	316.47 ms	45.18 ms
`c398f67`+dirty	315.08 ms	345.60 ms	30.52 ms
`76d1baf`+dirty	339.02 ms	408.65 ms	69.63 ms
`728164b`+dirty	335.93 ms	342.94 ms	7.01 ms
`4a6664f`+dirty	357.02 ms	394.91 ms	37.89 ms
`31fcca2`+dirty	366.64 ms	395.78 ms	29.14 ms
`52a8031`+dirty	330.72 ms	358.76 ms	28.03 ms

App size

Revision	Plain	With Sentry	Diff
`e540498`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`8ae23a7`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`12427f4`+dirty	7.15 MiB	8.12 MiB	997.78 KiB
`80b2ce3`+dirty	7.15 MiB	8.04 MiB	911.02 KiB
`c398f67`+dirty	7.15 MiB	8.21 MiB	1.07 MiB
`76d1baf`+dirty	7.15 MiB	8.09 MiB	964.41 KiB
`728164b`+dirty	7.15 MiB	8.12 MiB	997.71 KiB
`4a6664f`+dirty	7.15 MiB	8.22 MiB	1.07 MiB
`31fcca2`+dirty	7.15 MiB	8.18 MiB	1.03 MiB
`52a8031`+dirty	7.15 MiB	8.09 MiB	965.95 KiB

github-actions · 2024-10-28T08:40:58Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1230.04 ms	1237.10 ms	7.06 ms
Size	2.92 MiB	3.66 MiB	758.35 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`9c48b2c`+dirty	1253.39 ms	1256.30 ms	2.91 ms
`3853f43`+dirty	1271.74 ms	1278.04 ms	6.30 ms
`70e6261`+dirty	1224.90 ms	1231.02 ms	6.12 ms
`1d86dd6`+dirty	1289.25 ms	1293.36 ms	4.11 ms
`c398f67`+dirty	1227.31 ms	1230.00 ms	2.69 ms
`5bb8d5f`+dirty	1215.04 ms	1217.52 ms	2.48 ms
`d0bf494`+dirty	1266.20 ms	1267.52 ms	1.32 ms
`0d3e677`+dirty	1239.02 ms	1241.22 ms	2.20 ms
`0677344`+dirty	1252.52 ms	1254.08 ms	1.56 ms
`3ffcddd`+dirty	1272.22 ms	1273.98 ms	1.76 ms

App size

Revision	Plain	With Sentry	Diff
`9c48b2c`+dirty	2.92 MiB	3.41 MiB	499.97 KiB
`3853f43`+dirty	2.92 MiB	3.41 MiB	503.54 KiB
`70e6261`+dirty	2.92 MiB	3.59 MiB	686.11 KiB
`1d86dd6`+dirty	2.92 MiB	3.44 MiB	538.27 KiB
`c398f67`+dirty	2.92 MiB	3.60 MiB	701.89 KiB
`5bb8d5f`+dirty	2.92 MiB	3.48 MiB	575.85 KiB
`d0bf494`+dirty	2.92 MiB	3.40 MiB	488.08 KiB
`0d3e677`+dirty	2.92 MiB	3.66 MiB	758.42 KiB
`0677344`+dirty	2.92 MiB	3.41 MiB	500.94 KiB
`3ffcddd`+dirty	2.92 MiB	3.40 MiB	494.39 KiB

krystofwoldrich · 2024-10-28T11:50:13Z

Let's wait for RN 0.76.1 to fix CI builds. So we can merge this without 5555f27

lucas-zimerman

Overall looks ok, just a minor question in regard to the package usage, LGTM!

dev-packages/e2e-tests/package.json

krystofwoldrich added 5 commits October 24, 2024 10:55

chore(samples): Update gems

cf16bc8

chore(perf-samples): Remove unused deps and files

d3e7028

fix yarn lock file

4d1b67b

ref(e2e): Fetch received event in the tested app

96f2c86

Merge branch 'main' into kw/tests/fetch-event-in-sim

f5db3a0

krystofwoldrich requested review from antonis and lucas-zimerman as code owners October 28, 2024 07:50

Show error as text on screen instead of crashing the app

caba867

krystofwoldrich added 2 commits October 28, 2024 12:02

TMP Fix build

6bb13b8

tmp fix rn builds

5555f27

lucas-zimerman approved these changes Oct 28, 2024

View reviewed changes

dev-packages/e2e-tests/package.json Show resolved Hide resolved

krystofwoldrich merged commit 4297324 into main Oct 29, 2024
60 checks passed

krystofwoldrich deleted the kw/tests/fetch-event-in-sim branch October 29, 2024 14:41

Uh oh!

ref(e2e): Fetch received event in the tested app #4209

ref(e2e): Fetch received event in the tested app #4209

Uh oh!

Conversation

krystofwoldrich commented Oct 28, 2024

📢 Type of change

📜 Description

💚 How did you test it?

📝 Checklist

Uh oh!

github-actions bot commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

krystofwoldrich commented Oct 28, 2024

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Oct 28, 2024 •

edited

Loading

github-actions bot commented Oct 28, 2024 •

edited

Loading

github-actions bot commented Oct 28, 2024 •

edited

Loading

github-actions bot commented Oct 28, 2024 •

edited

Loading