-
Notifications
You must be signed in to change notification settings - Fork 615
ci: Testing the gh actions workflow for contribution violations #5897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,3 @@ | ||
| from sentry_sdk import profiler | ||
| from sentry_sdk import metrics | ||
| from sentry_sdk.scope import Scope | ||
| from sentry_sdk.transport import Transport, HttpTransport | ||
| from sentry_sdk.client import Client | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed imports break public API exports in
|
||
|
|
||
| from sentry_sdk.api import * # noqa | ||
| from sentry_sdk.consts import VERSION | ||
|
|
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed submodule imports for
profilerandmetricsMedium Severity
The explicit
from sentry_sdk import profilerandfrom sentry_sdk import metricsimports were removed, but"profiler"and"metrics"remain in__all__. These submodules are not re-exported bysentry_sdk.api's__all__, so they won't be eagerly available as attributes ofsentry_sdkafter package initialization. Code relying onsentry_sdk.profilerorsentry_sdk.metricswithout a direct import may break.