ci: Testing the gh actions workflow for contribution violations#5897
ci: Testing the gh actions workflow for contribution violations#5897gh-action-test wants to merge 1 commit intogetsentry:masterfrom
Conversation
|
This PR has been automatically closed. The referenced issue does not show a discussion between you and a maintainer. To avoid wasted effort on both sides, please discuss your proposed approach in the issue first and wait for a maintainer to respond before opening a PR. Please review our contributing guidelines for more details. |
|
This PR has been automatically converted to draft. All PRs must start as drafts per our contributing guidelines. Next steps:
|
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Langchain
Bug Fixes 🐛Ci
Openai
Other
Documentation 📚
Internal Changes 🔧Langchain
Openai
Other
Other
🤖 This preview updates automatically when you update the PR. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| from sentry_sdk import metrics | ||
| from sentry_sdk.scope import Scope | ||
| from sentry_sdk.transport import Transport, HttpTransport | ||
| from sentry_sdk.client import Client |
There was a problem hiding this comment.
Removed imports break public API exports in __all__
High Severity
The imports of Scope, Client, Transport, and HttpTransport were removed, but these names are still listed in __all__. Since from sentry_sdk.api import * only imports names from api.__all__ (which doesn't include these four), they no longer exist in the sentry_sdk namespace. This means from sentry_sdk import Scope will raise ImportError, sentry_sdk.Client will raise AttributeError, and from sentry_sdk import * will fail entirely.
| @@ -1,8 +1,3 @@ | |||
| from sentry_sdk import profiler | |||
| from sentry_sdk import metrics | |||
| from sentry_sdk.scope import Scope | |||
There was a problem hiding this comment.
Removed submodule imports for profiler and metrics
Medium Severity
The explicit from sentry_sdk import profiler and from sentry_sdk import metrics imports were removed, but "profiler" and "metrics" remain in __all__. These submodules are not re-exported by sentry_sdk.api's __all__, so they won't be eagerly available as attributes of sentry_sdk after package initialization. Code relying on sentry_sdk.profiler or sentry_sdk.metrics without a direct import may break.


Description
Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)