Skip to content

ci: Testing the gh actions workflow for contribution violations#5897

Closed
gh-action-test wants to merge 1 commit intogetsentry:masterfrom
gh-action-test:patch-1
Closed

ci: Testing the gh actions workflow for contribution violations#5897
gh-action-test wants to merge 1 commit intogetsentry:masterfrom
gh-action-test:patch-1

Conversation

@gh-action-test
Copy link
Copy Markdown

Description

Issues

Reminders

@gh-action-test gh-action-test requested a review from a team as a code owner March 27, 2026 10:47
@github-actions github-actions bot marked this pull request as draft March 27, 2026 10:47
@sdk-maintainer-bot sdk-maintainer-bot bot added violating-contribution-guidelines Used for automated community contribution checks. converted-to-draft Used for automated contribution checks. labels Mar 27, 2026
@sdk-maintainer-bot
Copy link
Copy Markdown

This PR has been automatically closed. The referenced issue does not show a discussion between you and a maintainer.

To avoid wasted effort on both sides, please discuss your proposed approach in the issue first and wait for a maintainer to respond before opening a PR.

Please review our contributing guidelines for more details.

@sdk-maintainer-bot
Copy link
Copy Markdown

This PR has been automatically converted to draft. All PRs must start as drafts per our contributing guidelines.

Next steps:

  1. Ensure CI passes
  2. Fill in the PR description completely
  3. Mark as "Ready for review" when you're done

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Langchain

  • Set gen_ai.operation.name and gen_ai.pipeline.name on LLM spans by ericapisani in #5849
  • Broaden AI provider detection beyond OpenAI and Anthropic by ericapisani in #5707
  • Update LLM span operation to gen_ai.generate_text by ericapisani in #5796

Bug Fixes 🐛

Ci

  • Use gh CLI to convert PR to draft by stephanie-anderson in #5874
  • Use GitHub App token for draft PR enforcement by stephanie-anderson in #5871

Openai

  • Always set gen_ai.response.streaming for Responses by alexander-alderman-webb in #5697
  • Simplify Responses input handling by alexander-alderman-webb in #5695
  • Use max_output_tokens for Responses API by alexander-alderman-webb in #5693
  • Always set gen_ai.response.streaming for Completions by alexander-alderman-webb in #5692
  • Simplify Completions input handling by alexander-alderman-webb in #5690
  • Simplify embeddings input handling by alexander-alderman-webb in #5688

Other

  • (google-genai) Guard response extraction by alexander-alderman-webb in #5869
  • (workflow) Fix permission issue with github app and PR draft graphql endpoint by Jeffreyhung in #5887

Documentation 📚

  • Update CONTRIBUTING.md with contribution requirements and TOC by stephanie-anderson in #5896

Internal Changes 🔧

Langchain

  • Add text completion test by alexander-alderman-webb in #5740
  • Add tool execution test by alexander-alderman-webb in #5739
  • Add basic agent test with Responses call by alexander-alderman-webb in #5726
  • Replace mocks with httpx types by alexander-alderman-webb in #5724
  • Consolidate span origin assertion by alexander-alderman-webb in #5723
  • Consolidate available tools assertion by alexander-alderman-webb in #5721

Openai

  • Replace mocks with httpx types for streaming Responses by alexander-alderman-webb in #5882
  • Replace mocks with httpx types for streaming Completions by alexander-alderman-webb in #5879
  • Move input handling code into API-specific functions by alexander-alderman-webb in #5687

Other

  • (ai) Rename generate_text to text_completion by ericapisani in #5885
  • (asyncpg) Normalize query whitespace in integration by ericapisani in #5855
  • Testing the gh actions workflow for contribution violations by gh-action-test in #5897
  • Merge PR validation workflows and add reason-specific labels by stephanie-anderson in #5898
  • Add workflow to close unvetted non-maintainer PRs by stephanie-anderson in #5895
  • Exclude compromised litellm versions by alexander-alderman-webb in #5876
  • Reactivate litellm tests by alexander-alderman-webb in #5853
  • Add note to coordinate with assignee before PR submission by sentrivana in #5868
  • Temporarily stop running litellm tests by alexander-alderman-webb in #5851

Other

  • ci+docs: Add draft PR enforcement by stephanie-anderson in #5867

🤖 This preview updates automatically when you update the PR.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

from sentry_sdk import metrics
from sentry_sdk.scope import Scope
from sentry_sdk.transport import Transport, HttpTransport
from sentry_sdk.client import Client
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed imports break public API exports in __all__

High Severity

The imports of Scope, Client, Transport, and HttpTransport were removed, but these names are still listed in __all__. Since from sentry_sdk.api import * only imports names from api.__all__ (which doesn't include these four), they no longer exist in the sentry_sdk namespace. This means from sentry_sdk import Scope will raise ImportError, sentry_sdk.Client will raise AttributeError, and from sentry_sdk import * will fail entirely.

Fix in Cursor Fix in Web

@@ -1,8 +1,3 @@
from sentry_sdk import profiler
from sentry_sdk import metrics
from sentry_sdk.scope import Scope
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed submodule imports for profiler and metrics

Medium Severity

The explicit from sentry_sdk import profiler and from sentry_sdk import metrics imports were removed, but "profiler" and "metrics" remain in __all__. These submodules are not re-exported by sentry_sdk.api's __all__, so they won't be eagerly available as attributes of sentry_sdk after package initialization. Code relying on sentry_sdk.profiler or sentry_sdk.metrics without a direct import may break.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-maintainer-discussion Used for automated community contribution checks. violating-contribution-guidelines Used for automated community contribution checks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants