Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve default app_path detection #89

Merged
merged 1 commit into from
Jul 26, 2017
Merged

Improve default app_path detection #89

merged 1 commit into from
Jul 26, 2017

Conversation

dcramer
Copy link
Member

@dcramer dcramer commented Jul 26, 2017

This uses the root of the directory which ensures things like routes and core versioned code are managed, but explicitly excludes vendor.

Refs GH-86

@dcramer dcramer requested a review from stayallive July 26, 2017 14:02
stayallive
stayallive approved these changes Jul 26, 2017
View reviewed changes
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 that was quick.

@dcramer
Improve default app_path detection
f91aea6 
This uses the root of the directory which ensures things like routes and core versioned code are managed, but explicitly excludes vendor.

Refs GH-86
@dcramer dcramer merged commit efdeeb1 into master Jul 26, 2017
@dcramer dcramer deleted the better-app-path branch July 26, 2017 14:14
@gonzalom gonzalom mentioned this pull request Apr 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stayallive stayallive stayallive approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcramer @stayallive