Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lumen app_path #128

Merged
merged 2 commits into from
Apr 18, 2018
Merged

Lumen app_path #128

merged 2 commits into from
Apr 18, 2018

Conversation

gonzalom
Copy link
Contributor

@gonzalom gonzalom commented Apr 17, 2018 •
edited
Loading

This uses the root of the directory which ensures things like routes and core versioned code are managed but explicitly excludes vendor.

This pull request is to apply in Lumen, the same changes applied for Laravel in #89.

Refs GH-86 and #89

@gonzalom gonzalom mentioned this pull request Apr 17, 2018
Closed
stayallive
stayallive approved these changes Apr 18, 2018
View reviewed changes
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this was definitely overlooked!

@stayallive stayallive merged commit 33ec181 into getsentry:master Apr 18, 2018
@gonzalom
Copy link
Contributor Author

No problem @stayallive, glad to contribute :)

@gonzalom gonzalom deleted the feature/lumen-app-path branch April 18, 2018 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stayallive stayallive stayallive approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gonzalom @stayallive