Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(replay): Bump rrweb to version 2.0.0-alpha.4 #6667

Closed
wants to merge 2 commits into from
Closed

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jan 5, 2023

This PR bumps rrweb to version 2.0.0-alpha.4 and adjusts the package patch which slightly changed for the new version.

I didn't find an official list of breaking changes or migrations for the new major. We've created an rrweb issue asking for a change log a while ago but so far only the relevant PRs were tagged. Out of those, nothing struck me as a breaking change for recording replays.

Furthermore, I compared the available replay options between 1.1.3 and 2.0.0-alpha.4 and didn't find any removed options or changed default values. v2 just adds a few new options, which shouldn't impact us.

New rrweb options:

  • ignoreCSSAttributes defaults to null
  • recordCrossOriginIframes defaults to false, so no need to disable it explicitly

Ultimately, I tested replays with my plain-js test app, using all our options for masking/ignoring/blocking which still seem to work as intended.

I'm fairly certain that the update doesn't break anything but I'm happy to test more if you (@billyvg @mydea) have more ideas.

Side note: I started doing this in an attempt to fix #6560 but it didn't seem to have impact for my testing. However, I think I'm still missing a good reproduction for the originally reported problem.

closes #6655

@Lms24 Lms24 requested review from mydea and billyvg January 5, 2023 15:47
@Lms24 Lms24 added the Package: replay Issues related to the Sentry Replay SDK label Jan 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.84 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 61.46 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.62 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 55 KB (+0.02% 🔺)
@sentry/browser - Webpack (gzipped + minified) 20.38 KB (-0.05% 🔽)
@sentry/browser - Webpack (minified) 66.55 KB (-0.14% 🔽)
@sentry/react - Webpack (gzipped + minified) 20.4 KB (-0.03% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.67 KB (-0.03% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.82 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.25 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 56.34 KB (+31.06% 🔺)
@sentry/replay - Webpack (gzipped + minified) 50.27 KB (+31.47% 🔺)

@Lms24
Copy link
Member Author

Lms24 commented Jan 5, 2023

Damn... +30% in bundle size 😮

Ok, something is going wrong with builds. Will revisit this on monday

@Lms24 Lms24 marked this pull request as draft January 5, 2023 16:16
@Lms24
Copy link
Member Author

Lms24 commented Jan 9, 2023

Closing this for now as we don't want to take the bundle size hit for the time being.

For future reference: The CI run shows quite cryptic build errors around missing modules which also blocked this PR. We'll need to fix this as well, whenever we revisit this.

Furthermore, we still know next to nothing about the new major and I'm suggesting to hold off from doing the upgrade until we know more (rrweb-io/rrweb#1059).

@Lms24 Lms24 closed this Jan 9, 2023
@Lms24 Lms24 deleted the lms-rrweb-2.0 branch December 3, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
1 participant