Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rrweb to version 2.x #6655

Closed
Lms24 opened this issue Jan 4, 2023 · 4 comments
Closed

Update rrweb to version 2.x #6655

Lms24 opened this issue Jan 4, 2023 · 4 comments
Assignees
Labels
Package: replay Issues related to the Sentry Replay SDK Type: Improvement

Comments

@Lms24
Copy link
Member

Lms24 commented Jan 4, 2023

Problem Statement

While our Replay integration is still in beta, we'd like to look into updating rrweb to version 2.x, thereby avoiding potentially breaking changes in a future stable state. Furthermore, v2 might improve certain aspects of rrweb, such as 3rd party iFrames (#6560).

Solution Brainstorm

Unfortunately, 2.x is still in an alpha state and development seems to be rather slow. However, we can still start with the update as we vendor a specific rrweb version anyway. This means we have full control over bumping to new 2.x alpha/beta/stable versions in the future.

Problems:

rrweb doesn't provide a migration guide or any information on breaking changes. I'm afraid, we'll need to test all our supported options and check that things still work as intended.

@Lms24 Lms24 added Type: Improvement Package: replay Issues related to the Sentry Replay SDK labels Jan 4, 2023
@Lms24 Lms24 self-assigned this Jan 4, 2023
@billyvg
Copy link
Member

billyvg commented Jan 4, 2023

Yeah I think we should look into v2 regardless of #6560, let me know if you want me to help test.

@Lms24
Copy link
Member Author

Lms24 commented Jan 9, 2023

Bundle size impact:

According to bundlephobia, rrweb 2.x is a roughly 25% increase in bundle size, compared to version 1.1.3. This raises the question if it's worth taking this hit over e.g. forking 1.1.3 and building/cherry-picking from there.

@Lms24
Copy link
Member Author

Lms24 commented Jan 25, 2023

Closing this as I don't think we're gonna tackle this any time soon. We can re-open if it comes up again.

@Lms24 Lms24 closed this as completed Jan 25, 2023
@Lms24
Copy link
Member Author

Lms24 commented Feb 7, 2023

Whenever we look at this, one compelling reason to upgrade is rrweb-io/rrweb#1107 (whenever it gets merged)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: replay Issues related to the Sentry Replay SDK Type: Improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants