forked from rrweb-io/rrweb
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish our forked rrweb
packages to NPM
#15
Comments
Arguably, this issue rather belongs into https://github.com/getsentry/rrweb but we currently can't create issues there. Happy to move it, once we can open issues (@bruno-garcia do you have the necessary permissions to enable issues?) |
|
This was referenced Jan 19, 2023
Lms24
added a commit
to getsentry/sentry-javascript
that referenced
this issue
Jan 26, 2023
As outlined in getsentry/rrweb#15, we're now releasing packages of our rrrweb fork: * replace the original rrweb dependency with our forked one * remove the patches for the original rrweb dependency which we now don't need anymore * remove the `patch-package` dev dependency, as we're not patching any package anymore In terms of building the rrweb package, nothing changes - we're still inlining the rrweb code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem Statement
Because of bugs in rrweb, its slow development cycle, and the fact that they're working on v2 (which is also problematic on its own, getsentry/sentry-javascript#6655) we have to apply multiple patches to the library, and bundle it into our
@sentry/replay
package. This has a number of drawbacks:patch-package
has grown enormously (10k lines; see feat(replay): Update rrweb & rrweb-snapshot sentry-javascript#6749)Solution Brainstorm
In a first step, to make developing patches on rrweb v1 easier, we update our rrweb fork in which we now create and merge PRs which we then use to patch the actual rrweb package.
We now propose to release our rrweb fork (e.g.
@sentry-internal/rrweb
) to NPM so we can stop patching the official package all together and just use our fork like a regular dependency. The steps to get this done are:#15 (comment)
#15 (comment)
#15 (comment)
For the most part, we can follow our SDK release checklist to make sure we've covered everything necessary.
Furthermore, we can also take getsentry/sentry-javascript-bundler-plugins#60 as an inspiration, where we recently started releasing to NPM from a new repo.
The text was updated successfully, but these errors were encountered: