-
-
Notifications
You must be signed in to change notification settings - Fork 465
Filter out app starts with more than 60s #2127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
c926d14
d40bf43
032f4fb
c643a56
9cc1b37
7d206c0
a23a6b6
0d0edca
6dd2eab
ab0b5f3
964236b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -77,4 +77,16 @@ class AppStartStateTest { | |
|
|
||
| assertEquals(400, sut.appStartInterval) | ||
| } | ||
|
|
||
| @Test | ||
| fun `getAppStartInterval returns null if more than 60s`() { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think this is unnecessary, we already test above and lower the boundary.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If someone changes the MAX_APP_START_MILLIS to 10000000, no test will fail. Up to you. |
||
| val sut = AppStartState.getInstance() | ||
|
|
||
| val date = Date() | ||
| sut.setAppStartTime(100, date) | ||
| sut.setAppStartEnd(70000) | ||
marandaneto marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| sut.setColdStart(true) | ||
|
|
||
| assertNull(sut.appStartInterval) | ||
| } | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.