Skip to content

Filter out app starts with more than 60s #2127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marandaneto merged 11 commits into from
Jun 24, 2022
Merged

Filter out app starts with more than 60s #2127

marandaneto merged 11 commits into from
Jun 24, 2022

Conversation

@marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jun 22, 2022 •
edited
Loading

📜 Description

Filter out app starts with more than 60s

💡 Motivation and Context

getsentry/sentry-react-native#2295

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto mentioned this pull request Jun 22, 2022
Closed
@bruno-garcia
Copy link
Member

bruno-garcia commented Jun 22, 2022

Oh cocoa the cutoff was 5 min. Is one value more likely to be legit than the other?

@marandaneto
Copy link
Contributor Author

marandaneto commented Jun 22, 2022

Oh cocoa the cutoff was 5 min. Is one value more likely to be legit than the other?

No, Also 60s getsentry/sentry-cocoa#1899

@marandaneto marandaneto mentioned this pull request Jun 23, 2022
Closed
adinauer
adinauer approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some nits, LGTM!

philipphofmann
philipphofmann approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

sentry-android-core/src/test/java/io/sentry/android/core/AppStartStateTest.kt
}

@Test
fun `getAppStartInterval returns null if more than 60s`() {
Copy link
Member

@philipphofmann philipphofmann Jun 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: We could add another test with the max app start duration of 59999 ms to validate it is working correctly.

Copy link
Contributor Author

@marandaneto marandaneto Jun 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is unnecessary, we already test above and lower the boundary.
The comparison is a simple >= with a long value rather than some more complicated calculation.
I can do it but sounds like not needed, your call.

Copy link
Member

@philipphofmann philipphofmann Jun 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone changes the MAX_APP_START_MILLIS to 10000000, no test will fail. Up to you.

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2022 •
edited
Loading

Codecov Report

Merging #2127 (6dd2eab) into main (b5ef9c5) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2127   +/-   ##
=========================================
  Coverage     80.93%   80.93%           
  Complexity     3254     3254           
=========================================
  Files           231      231           
  Lines         11951    11951           
  Branches       1586     1586           
=========================================
  Hits           9673     9673           
  Misses         1698     1698           
  Partials        580      580

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5ef9c5...6dd2eab. Read the comment docs.

philipphofmann
philipphofmann approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@marandaneto marandaneto enabled auto-merge (squash) June 24, 2022 06:25
@marandaneto marandaneto merged commit 4a0e412 into main Jun 24, 2022
@marandaneto marandaneto deleted the fix/filter-appstart-60s branch June 24, 2022 06:29
@marandaneto marandaneto mentioned this pull request Jun 28, 2022
Merged
8 tasks
@github-actions github-actions bot mentioned this pull request Jul 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adinauer adinauer adinauer approved these changes

@philipphofmann philipphofmann philipphofmann approved these changes

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@marandaneto @bruno-garcia @codecov-commenter @philipphofmann @adinauer