fix: Crash in SentryLogger if removed early #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mujacica
approved these changes
Aug 25, 2025
bruno-garcia
approved these changes
Aug 25, 2025
Member
bruno-garcia
left a comment
bruno-garcia
left a comment
There was a problem hiding this comment.
is there a way to repro and test this?
Collaborator
Author
|
@bruno-garcia not without #321, we'll have tests there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash issue revealed while working on tests in #321. Using callable_mp with call_deferred is not safe if object is removed early. Using method bindings with call_deferred() is much safer in this context. Extracted from #321.
Also better error handling.